Repository navigation
Fix ProcessPoolExecutor hang when a worker is killed mid-result - #159696
Closed
junaidkhan80121 wants to merge 1 commit into
Closed
junaidkhan80121 wants to merge 1 commit into
junaidkhan80121 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
… mid-result A worker killed after writing part of a large result left the manager thread blocked in Connection.recv(). The parent holds the result pipe's write end, so that death is not delivered as EOF. Watch worker sentinels for the rest of the message and raise BrokenProcessPool. Co-authored-by: Cursor <cursoragent@cursor.com>
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Closing this pull request. I will open the change myself. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A ProcessPoolExecutor worker killed while writing a large result left the future pending and blocked interpreter shutdown. Connection.recv() now watches worker sentinels for the rest of the message and raises BrokenProcessPool. Callers that do not pass sentinels keep the previous behavior.
Test plan