Repository navigation
gh-159715: Fix ZoneInfo TZ rules spanning year boundaries - #159722
Open
pganssle wants to merge 5 commits into
Open
pganssle wants to merge 5 commits into
pganssle wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
TZ string lookups only considered rules from the datetime's year, even when an offset or extended transition time moved a rule into a different year. Consider neighboring DST periods and join touching periods so that permanent DST does not introduce a gap or fold at New Year. Determine folds from actual offset changes. This also avoids marking times as ambiguous when the first occurrence would have fallen in a gap at the start of a short DST period. Keep the Python single-year lookup away from year boundaries when the rule order cannot change between years, to avoid scanning neighboring periods for ordinary footer lookups. Add regressions for both implementations, including positive and negative DST, extended transition hours, and datetime's extreme years.
pganssle
commented
Oct 19, 2026
Comment thread
Lib/test/test_zoneinfo/test_zoneinfo.py
Comment thread
Lib/test/test_zoneinfo/test_zoneinfo.py
Comment thread
Lib/zoneinfo/_zoneinfo.py
Outdated
Comment thread
Lib/zoneinfo/_zoneinfo.py
Outdated
pganssle
commented
Oct 19, 2026
Comment thread
Lib/zoneinfo/_zoneinfo.py
Outdated
Comment thread
Lib/zoneinfo/_zoneinfo.py
Outdated
Comment thread
Lib/zoneinfo/_zoneinfo.py
Outdated
Comment thread
Lib/zoneinfo/_zoneinfo.py
Outdated
pganssle
commented
Oct 19, 2026
Comment thread
Lib/zoneinfo/_zoneinfo.py
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159715.
TZ footer rules can put a transition in a different year from the rule that defines it. The lookup now considers neighboring DST periods, including periods that touch to represent permanent DST. This fixes incorrect offsets and UTC round trips near New Year in both implementations. Folds are based on an actual decrease in offset, so dummy transitions between permanent-DST periods don't create a fold.
The tests cover positive and negative DST, displaced start and end rules, extended transition hours, years 1 and 9999, and short DST periods where only part of the nominal fold is ambiguous. The Python implementation retains a single-year lookup away from year boundaries when the rules are far enough apart that their order cannot change between years.
Validation: ./python -m test test_zoneinfo passes on a debug build. The year-boundary regressions fail with the original implementations restored.