Repository navigation
gh-159759: Fix libpython.static in PEP 739 build-details.json - #159766
Merged
itamaro merged 2 commits intoOct 20, 2026
Merged
itamaro merged 2 commits into
itamaro merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
When a shared library is also built, `make install` only installs the static library into LIBPL, so point libpython.static there instead of LIBDIR. Static-only builds keep the existing LIBDIR path, which is installed in that configuration. Framework builds don't install the static library (LIBPL contains a symlink to the framework's shared library instead), so don't list it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
brettcannon
approved these changes
Oct 19, 2026
brettcannon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Just some minor stylistic things.
Also note I'm no expert in this area, so my review should be taken with a grain of salt.
Sorry, something went wrong.
Comment thread
Lib/test/test_build_details.py
Outdated
Comment thread
Lib/test/test_build_details.py
Outdated
Comment thread
Lib/test/test_build_details.py
Outdated
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2CKGDURpDRVEHD7FfWnps
corona10
approved these changes
Oct 20, 2026
corona10
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm!
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @itamaro for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-159823 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-159824 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
itamaro
added a commit
that referenced
this pull request
Oct 20, 2026
…H-159766) (#159824) gh-159759: Fix libpython.static in PEP 739 build-details.json (GH-159766) When a shared library is also built, point `libpython.static` at `LIBPL`, the only place `make install` puts the static library, and don't list it for framework builds, which don't install one. Static-only builds keep the existing `LIBDIR` value, which is installed in that configuration. (cherry picked from commit e41b38b) Co-authored-by: Itamar Oren <itamarost@gmail.com>
itamaro
added a commit
that referenced
this pull request
Oct 20, 2026
…H-159766) (#159823) gh-159759: Fix libpython.static in PEP 739 build-details.json (GH-159766) When a shared library is also built, point `libpython.static` at `LIBPL`, the only place `make install` puts the static library, and don't list it for framework builds, which don't install one. Static-only builds keep the existing `LIBDIR` value, which is installed in that configuration. (cherry picked from commit e41b38b) Co-authored-by: Itamar Oren <itamarost@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a shared library is also built, point libpython.static at LIBPL,
the only place make install puts the static library, and don't list it for
framework builds, which don't install one. Static-only builds keep the
existing LIBDIR value, which is installed in that configuration.
Written with assistance from Claude Code Opus 5.5