Repository navigation
gh-159739: Skip code-extra cleanup callbacks for NULL data - #159768
Closed
jelle-openai wants to merge 1 commit into
Closed
jelle-openai wants to merge 1 commit into
jelle-openai wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Backport to 3.15 and 3.14.
Copy link
Copy Markdown
Contributor
Author
|
The problem this fixes is that callbacks may be incorrectly called with a NULL argument, contrary to the docs. But this is unstable anyway, changing the behavior is itself risky, and I don't think it's really worth changing. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport to 3.15 and 3.14.