FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-159739: Avoid leaking references during free-threaded GC enumeration by jelle-openai · Pull Request #159781 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-159739: Avoid leaking references during free-threaded GC enumeration #159781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 1 commit into from
Oct 20, 2026
Conversation 3 Commits 1 Checks 64 Files changed
Merged

gh-159739: Avoid leaking references during free-threaded GC enumeration #159781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .c  (1) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-10-19-20-38-17.gh-issue-159739.55fd08.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix a reference leak in :func:`gc.get_objects` and :func:`gc.get_referrers`
when an internal allocation fails in the free-threaded build.
6 changes: 4 additions & 2 deletions Python/gc_free_threading.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2412,9 +2412,10 @@ visit_get_referrers(const mi_heap_t *heap, const mi_heap_area_t *area,
return true;
}
if (Py_TYPE(op)->tp_traverse(op, referrersvisit, arg->objs)) {
if (_PyObjectStack_Push(&arg->results, Py_NewRef(op)) < 0) {
if (_PyObjectStack_Push(&arg->results, op) < 0) {
return false;
}
Py_INCREF(op);
}

return true;
Expand Down Expand Up @@ -2459,9 +2460,10 @@ visit_get_objects(const mi_heap_t *heap, const mi_heap_area_t *area,
}

struct get_objects_args *arg = (struct get_objects_args *)args;
if (_PyObjectStack_Push(&arg->objects, Py_NewRef(op)) < 0) {
if (_PyObjectStack_Push(&arg->objects, op) < 0) {
return false;
}
Py_INCREF(op);
return true;
}

Expand Down
Loading
Back | FazBrowse Home | New Git URL