Repository navigation
[3.15] gh-157384: Document and test PyImport_CreateModuleFromInitfunc() semantics (GH-157389) - #159791
Merged
itamaro merged 1 commit intoOct 19, 2026
Merged
[3.15] gh-157384: Document and test PyImport_CreateModuleFromInitfunc() semantics (GH-157389)#159791itamaro merged 1 commit into
itamaro merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…) semantics (pythonGH-157389) Document that single-phase init modules are added to sys.modules by the call itself (unlike multi-phase init modules), and that the spec name identifies the module, so a later call with the same name and a different init function reuses the cached module without calling the new init function. Add regression tests for both behaviors. (cherry picked from commit 0c4ca17) Co-authored-by: Itamar Oren <itamarost@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com>
miss-islington
requested review from
FFY00,
ZeroIntensity,
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
October 19, 2026 21:44
4 tasks
Copy link
Copy Markdown
Documentation build overview143 files changed · + 1 added · ± 137 modified · - 5 deleted + Added ± Modified
- Deleted |
Sorry, something went wrong.
itamaro
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that single-phase init modules are added to sys.modules by
the call itself (unlike multi-phase init modules), and that the spec
name identifies the module, so a later call with the same name and a
different init function reuses the cached module without calling the
new init function. Add regression tests for both behaviors.
(cherry picked from commit 0c4ca17)
Co-authored-by: Itamar Oren itamarost@gmail.com
Co-authored-by: Petr Viktorin encukou@gmail.com