FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-159815: do not leave stale OpenSSL errors in `_hashlib` by picnixz · Pull Request #159816 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-159815: do not leave stale OpenSSL errors in _hashlib #159816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
picnixz wants to merge 4 commits into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 1 Commits 4 Checks 54 Files changed
Draft

gh-159815: do not leave stale OpenSSL errors in _hashlib #159816

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e0a106
gh-159815: do not leave stale OpenSSL errors in `_hashlib`
picnixz Oct 19, 2026
16cd716
add NEWS entry
picnixz Oct 19, 2026
0a4837e
add test
picnixz Oct 20, 2026
61f6e5e
Merge branch 'main' into meta/crypto/c/hashlib/34/openssl-peek-error-…
picnixz Oct 20, 2026
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
Next Next commit
add test
  • Loading branch information
picnixz committed Oct 20, 2026
commit 0a4837efce355c6b3a0578fcbb492c019a792795
12 changes: 12 additions & 0 deletions Lib/test/test_hashlib.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1440,6 +1440,18 @@ def scrypt(password=b"password", /, **kwargs):
MAX_DKLEN = ((1 << 32) - 1) * 32 # see RFC 7914
self.assertRaises(numeric_exc_types, scrypt, dklen=MAX_DKLEN + 1)

def test_scrypt_stale_openssl_error(self):
# gh-159815: a failed algorithm lookup must not leave an error in
# the OpenSSL error queue that a later unrelated failure reports.
def get_error_message():
with self.assertRaises(ValueError) as cm:
hashlib.scrypt(b'password', salt=b'salt', n=2, r=0, p=1)
return str(cm.exception)

expect = get_error_message()
self.assertRaises(ValueError, _hashlib.new, 'no_such_algorithm')
self.assertEqual(get_error_message(), expect)


@threading_helper.requires_working_threading()
class TestTSAN(unittest.TestCase):
Expand Down
Loading
Back | FazBrowse Home | New Git URL