FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-159693: Format import errors with no usable search paths by limadog9 · Pull Request #159830 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-159693: Format import errors with no usable search paths #159830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
limadog9 wants to merge 1 commit into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 0 Commits 1 Checks 51 Files changed
Open

gh-159693: Format import errors with no usable search paths #159830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (2) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
14 changes: 14 additions & 0 deletions Lib/test/test_traceback.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -5325,6 +5325,20 @@ def test_windows_only_module_error(self):
else:
self.fail("ModuleNotFoundError was not raised")

def test_module_not_found_without_search_paths(self):
importlib.import_module('importlib.resources.readers')
error = ModuleNotFoundError("No module named 'missing_module'",
name='missing_module')
with os_helper.temp_dir() as tmp:
for paths in ([], [os.path.join(tmp, 'missing')]):
with self.subTest(paths=paths):
with support.swap_attr(sys, 'path', paths):
self.assertEqual(
traceback.format_exception_only(error),
["ModuleNotFoundError: No module named "
"'missing_module'\n"],
)

@unittest.skipIf(not importlib.machinery.EXTENSION_SUFFIXES, 'Platform does not support extension modules')
def test_find_incompatible_extension_modules(self):
"""_find_incompatible_extension_modules assumes the last extension in
Expand Down
7 changes: 4 additions & 3 deletions Lib/traceback.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2106,9 +2106,10 @@ def _find_incompatible_extension_module(module_name):
if parent:
traversable = importlib.resources.files(parent)
else:
traversable = importlib.resources.readers.MultiplexedPath(
*map(pathlib.Path, filter(os.path.isdir, sys.path))
)
paths = list(map(pathlib.Path, filter(os.path.isdir, sys.path)))
if not paths:
return
traversable = importlib.resources.readers.MultiplexedPath(*paths)

for entry in traversable.iterdir():
if entry.name.startswith(child + '.') and entry.name.endswith(untagged_suffix):
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-10-20-02-01-00.gh-issue-159693.6Rky2a.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix formatting of :exc:`ModuleNotFoundError` when :data:`sys.path` contains
no existing directories, including when displaying errors in the REPL.
Loading
Back | FazBrowse Home | New Git URL