Repository navigation
gh-159739: Respect readline limits after a short read - #159974
Merged
JelleZijlstra merged 1 commit intoOct 22, 2026
Merged
JelleZijlstra merged 1 commit into
JelleZijlstra merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Backport to 3.15 and 3.14. Both branches use a bytearray instead of PyBytesWriter; the test lives in Lib/test/test_io.py on 3.14.
Copy link
Copy Markdown
|
Thanks @jelle-openai for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @jelle-openai and @JelleZijlstra, I could not cleanly backport this to 3.14 due to a conflict. Please backport manually with cherry_picker, see the devguide for more information. cherry_picker 87eaef117191037cebce2becea5350ff4f45dee3 3.14 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-160246 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-160483 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a binary IOBase subclass provides peek() and read() returns fewer bytes than requested, readline(size) calculates subsequent reads against the original limit instead of the number of bytes still allowed. It can consume and return more than size bytes, leaving less data for the next read. Apply the remaining limit in both the C and pure-Python implementations.
Backport to 3.15 and 3.14. Both branches use a bytearray instead of PyBytesWriter; the test lives in Lib/test/test_io.py on 3.14.