Repository navigation
gh-159739: Do not intern complex subclasses in code constants - #159980
Merged
JelleZijlstra merged 2 commits intoOct 22, 2026
Merged
JelleZijlstra merged 2 commits into
JelleZijlstra merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Backport to 3.15 and 3.14.
aisk
reviewed
Oct 21, 2026
Comment thread
Lib/test/test_code.py
Outdated
aisk
approved these changes
Oct 22, 2026
Copy link
Copy Markdown
|
Thanks @jelle-openai for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-160249 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-160250 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
JelleZijlstra
pushed a commit
that referenced
this pull request
Oct 22, 2026
JelleZijlstra
pushed a commit
that referenced
this pull request
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not intern complex subclasses in code constants. On free-threaded builds, the code-constant interning check accepts complex subclasses instead of only exact complex objects. An instance supplied through code.replace(co_consts=...) can therefore run a user-defined __hash__ during code-object creation and become immortal, unexpectedly retaining the instance and anything it references.
Backport to 3.15 and 3.14.