Repository navigation
[3.15] gh-159819: Fix python-config.sh for installation paths containing spaces (GH-159820) - #160184
Merged
itamaro merged 1 commit intoOct 22, 2026
Merged
itamaro merged 1 commit into
itamaro merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ng spaces (pythonGH-159820) The shell `python-config` located its own prefix with unquoted command substitutions, so any whitespace in the installation path made it print an empty `--prefix` and `-I/include/...`-style paths while exiting 0. - Quote the substitutions and the argument loop (POSIX `sh`, no bashisms). - Exit 1 with a message when the script's directory cannot be resolved, instead of silently printing empty paths. - Replace `sed "s#$prefix#$prefix_real#"` with a `relocate` helper using parameter expansion, so `#`, `&`, `\` and regex metacharacters in either prefix are handled literally. Same first-occurrence semantics. - Add `test_python_config_sh_prefix_with_spaces`: runs the generated script from `…/path with spaces/bin/` and checks `--prefix`, `--exec-prefix`, `--includes` and empty stderr (cherry picked from commit 3e13407) Co-authored-by: Itamar Oren <itamarost@gmail.com>
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shell python-config located its own prefix with unquoted command
substitutions, so any whitespace in the installation path made it print an
empty --prefix and -I/include/...-style paths while exiting 0.
instead of silently printing empty paths.
parameter expansion, so #, &, \ and regex metacharacters in either
prefix are handled literally. Same first-occurrence semantics.
generated script from …/path with spaces/bin/ and checks --prefix,
--exec-prefix, --includes and empty stderr
(cherry picked from commit 3e13407)
Co-authored-by: Itamar Oren itamarost@gmail.com