Repository navigation
gh-159739: Handle overlapping mmap writes - #160189
Open
jelle-openai wants to merge 2 commits into
Open
jelle-openai wants to merge 2 commits into
jelle-openai wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Writing a memoryview of an mmap back into an overlapping region, through write() or contiguous slice assignment, used memcpy(), which has undefined behavior for overlapping ranges and can corrupt the mapped data. Use overlap-safe copying for both operations. Backport to 3.15 and 3.14.
Comment thread
Modules/mmapmodule.c
| if (safe_copy_from_slice(self->data, (char *)vbuf.buf, start, step, | ||
| slicelen) < 0) | ||
| { | ||
| /* The source may overlap the destination, so copy it before |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Feels like this can hurt performance, let's look for a better solution.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing a memoryview of an mmap back into an overlapping region, through write() or contiguous slice assignment, used memcpy(), which has undefined behavior for overlapping ranges and can corrupt the mapped data. Use overlap-safe copying for both operations. Backport to 3.15 and 3.14.