Repository navigation
[3.14] gh-159739: Detect recursive untyped ctypes arguments (GH-160194) - #160351
Merged
JelleZijlstra merged 1 commit intoOct 22, 2026
Merged
JelleZijlstra merged 1 commit into
JelleZijlstra merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…160194) _as_parameter_ chains were recursion-checked for typed arguments but not for foreign calls without argtypes. A cyclic chain could exhaust the C stack and crash before the function was called. Apply the same recursion guard to untyped conversion. Backport to 3.15 and 3.14. (cherry picked from commit 3e19e04) Co-authored-by: Jelle Zijlstra <jelle@openai.com>
miss-islington
force-pushed
the
backport-3e19e04-3.14
branch
from
4b90d24 to
adfdf5b
Compare
October 22, 2026 21:16
This was referenced Oct 22, 2026
JelleZijlstra
enabled auto-merge (squash)
October 22, 2026 22:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as_parameter chains were recursion-checked for typed arguments but not for foreign calls without argtypes. A cyclic chain could exhaust the C stack and crash before the function was called. Apply the same recursion guard to untyped conversion. Backport to 3.15 and 3.14.
(cherry picked from commit 3e19e04)
Co-authored-by: Jelle Zijlstra jelle@openai.com