Repository navigation
bpo-38140: Make dict and weakref offsets opaque for C heap types - #16076
Merged
DinoV merged 2 commits intoSep 19, 2019
Merged
DinoV merged 2 commits into
DinoV merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ericsnowcurrently
self-requested a review
September 13, 2019 11:11
DinoV
approved these changes
Sep 14, 2019
Copy link
Copy Markdown
|
@DinoV: Please replace # with GH- in the commit message next time. Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes tp_dictoffset and tp_weaklistoffset completely opaque for C heap allocated types created through PyType_FromSpec.
The type system already provides a way to pass in readonly primitive types. This uses that mechanism to pass in the offset values through the two keywords: __dictoffset__ and __weaklistoffset__. This then extends the type system to sniff for these values to set the offsets into the type.
To provide uniformity, the passed in member types are required to have a T_PYSSIZET as well as being READONLY
https://bugs.python.org/issue38140