| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Hi! Thanks for improving the documentation!
In this commit you rewrapped a lot of paragraphs without changing them, which is bad for the log readability. (It mess with git blame, it's hard to review as it's long to find the actual modification, ...).
Can you please rollback those changes and do a minimal commit with just the removal of the duplicate word? I bet the paragraph containing the removed word don't needs rewrapping neither after the removal.
You can simply add a new commit to your branch and push it, as anyway both commits will be squashed while being merged: you don't have to force push, just add a new commit.
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
|
As you did it in two separate commit (good) you can simply run git revert 89dbf912798b8440d67f4ab8184c85bafa29dd2b (and git push). |
Sorry, something went wrong.
|
I have made the requested changes; please review again But, I made a revert wrong. Then I reverted the revert. :/ If you prefer, I can redo the PR from scratch. My bad. |
Sorry, something went wrong.
|
Thanks for making the requested changes! @JulienPalard: please review the changes made to this pull request. |
Sorry, something went wrong.
|
Thanks @adorilson for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Sorry, something went wrong.
|
Sorry @adorilson and @JulienPalard, I had trouble checking out the 3.8 backport branch. |
Sorry, something went wrong.
|
@adorilson thanks! The series of revert if not a problem as we squash before merging, see: b7af4e7 it's clean. |
Sorry, something went wrong.
|
Thanks @adorilson for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Sorry, something went wrong.
|
GH-16177 is a backport of this pull request to the 3.8 branch. |
Sorry, something went wrong.
(cherry picked from commit b7af4e7) Co-authored-by: Adorilson Bezerra <adorilson@gmail.com>
| Back | FazBrowse Home | New Git URL |
Just remove duplicate word in sentence: