FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore by vstinner · Pull Request #16509 · python/cpython · GitHub

/ cpython Public

bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore - #16509

Merged
vstinner merged 2 commits into
python:masterfrom
vstinner:pyconfig_init
Oct 1, 2019
ConversationCommits (2)ChecksFiles changed
Merged

bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore#16509
vstinner merged 2 commits into
python:masterfrom
vstinner:pyconfig_init

Conversation

vstinner commented Oct 1, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no
longer return PyStatus: they cannot fail anymore.

https://bugs.python.org/issue38304

bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore
20fb112 
PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no
longer return PyStatus: they cannot fail anymore.

vstinner commented Oct 1, 2019

Copy link
Copy Markdown
Member Author

I forgot to update PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() in my PR #16500. There is no more need to return PyStatus since these functions cannot fail anymore. They don't allocate any memory: strings are initialized to NULL, lists to empty lists (which doesn't allocate any memory).

vstinner mentioned this pull request Oct 1, 2019
Merged

vstinner commented Oct 1, 2019

Copy link
Copy Markdown
Member Author

cc @ncoghlan @ambv That can wait for 3.8.0rc2 or 3.8.0 final if it's too late for rc1.

ambv approved these changes Oct 1, 2019
View reviewed changes

ambv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Wait for CI and merge.

vstinner merged commit 8462a49 into python:master Oct 1, 2019
vstinner deleted the pyconfig_init branch October 1, 2019 10:06

miss-islington commented Oct 1, 2019

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

bedevere-bot commented Oct 1, 2019

Copy link
Copy Markdown

GH-16510 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 1, 2019
bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore (GH-16509)
d49f096 
PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no
longer return PyStatus: they cannot fail anymore.
(cherry picked from commit 8462a49)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

ncoghlan commented Oct 1, 2019

Copy link
Copy Markdown
Contributor

Good catch!

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore (pythonGH-…
23b6e22 
…16509)

PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no
longer return PyStatus: they cannot fail anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ambv ambv approved these changes
brettcannon Awaiting requested review from brettcannon
encukou Awaiting requested review from encukou
ericsnowcurrently Awaiting requested review from ericsnowcurrently
ncoghlan Awaiting requested review from ncoghlan
warsaw Awaiting requested review from warsaw

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL