Repository navigation
bpo-38396: dump(node) instead of repr(node) on ast.literal_eval - #16620
Closed
isidentical wants to merge 1 commit into
Closed
isidentical wants to merge 1 commit into
isidentical wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
vstinner
reviewed
Dec 14, 2019
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Can you please try to write a test?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
bpo-38396 resolved as duplicate of bpo-32888 and #340 is about fixing it. It has a slightly different approach but resolves the same problem so I think this PR can be closed. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Oh, @ilevkivskyi seems to be against this PR, so I close it: https://bugs.python.org/issue38396#msg354132 I agree that PR #340 should produce shorter and better error message. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38396