Repository navigation
gh-71652: Make IDLE help source menu entries unique and sorted - #17093
ZackerySpytz wants to merge 1 commit into
Conversation
Sorry, something went wrong.
taleinat
left a comment
There was a problem hiding this comment.
Great PR overall! Just two comments for your consideration.
Sorry, something went wrong.
| self.user_helplist = idleConf.GetAllExtraHelpSourcesList() | ||
| self.set_additional_help_sources() | ||
|
|
||
| def set_additional_help_sources(self): |
There was a problem hiding this comment.
IMO this method should also be setting self.user_helplist = idleConf.GetAllExtraHelpSourcesList() rather than assuming it is set elsewhere before it is called.
Sorry, something went wrong.
| Additional help sources may be added here with the Configure IDLE dialog under | ||
| the General tab. See the :ref:`Help sources <help-sources>` subsection below | ||
| for more on Help menu choices. | ||
| Additional help sources |
There was a problem hiding this comment.
IMHO giving more details here is counter-productive. That the menu items must be unique and sorted are rather minor, technical details. And I find this sentence to be stating the obvious: "The allowed file types may depend on the system." As for checking things when submitted, users will discover that themselves when using the feature, and I'm really not sure documenting it here is valuable.
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
|
This PR has not been touched by a human in more than 5 years. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer on the related issue. |
Sorry, something went wrong.
https://bugs.python.org/issue27465