[WIP] gh-82987: bdb: stop_here: always stop at calling frame - #17159
Draft
blueyed wants to merge 2 commits into
Draft
[WIP] gh-82987: bdb: stop_here: always stop at calling frame#17159blueyed wants to merge 2 commits into
blueyed wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
1 task
Copy link
Copy Markdown
Contributor
Author
|
Note: with pdbpp I am remembering the frame in Pdb.set_trace already, which could be an option here also? |
Sorry, something went wrong.
blueyed
added a commit
to blueyed/pdbpp
that referenced
this pull request
Nov 19, 2019
This is relevant for when `skip` is used. Ref: https://bugs.python.org/issue38806 Ref: python/cpython#17159 NOTE: pypy2: needs the extra check for frame, which makes sense in general (via test_sigint_in_interaction_without_new_cmdloop).
blueyed
added a commit
to pdbpp/pdbpp
that referenced
this pull request
Nov 19, 2019
This is relevant for when `skip` is used. Ref: https://bugs.python.org/issue38806 Ref: python/cpython#17159 NOTE: pypy2: needs the extra check for frame, which makes sense in general (via test_sigint_in_interaction_without_new_cmdloop).
The following will not stop for debugging:
python3.8 -c 'import pdb; pdb.Pdb(skip=["*"]).set_trace()'
The example is contrived, the real case would be to have some "noisy"
module being excluded in general, but when you add an explicit
"set_trace()" in there it should still stop there, and not on some upper
frame.
This was changed a long time already in
python@313a751
(Python 2.3), but it is not really clear.
This PR is meant to see how reverting that part goes.
blueyed
force-pushed
the
is_skipped_module-stop-at-set_trace
branch
from
1c2e81e to
cc60f41
Compare
September 18, 2021 08:26
serhiy-storchaka
marked this pull request as draft
January 17, 2024 20:08
Copy link
Copy Markdown
|
The following commit authors need to sign the Contributor License Agreement: |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following will not stop for debugging:
The example is contrived, the real case would be to have some "noisy"
module being excluded in general, but when you add an explicit
"set_trace()" in there it should still stop there, and not on some upper
frame.
This was changed a long time already in
313a751
(Python 2.3), but it is not really clear.
/cc @ctismer
This PR is meant to see how reverting that part goes.
https://bugs.python.org/issue38806