FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-38818: PyInterpreterState.eval_frame now pass tstate by vstinner · Pull Request #17187 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-38818: PyInterpreterState.eval_frame now pass tstate - #17187

Closed
vstinner wants to merge 1 commit into
python:masterfrom
vstinner:eval_frame_tstate
ConversationCommits (1)ChecksFiles changed
Closed

bpo-38818: PyInterpreterState.eval_frame now pass tstate#17187
vstinner wants to merge 1 commit into
python:masterfrom
vstinner:eval_frame_tstate

Conversation

vstinner commented Nov 16, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

PyInterpreterState.eval_frame (PEP 523) now requires a new mandatory
tstate parameter (PyThreadState*).

https://bugs.python.org/issue38818

bpo-38818: PyInterpreterState.eval_frame now pass tstate
224ec94 
PyInterpreterState.eval_frame (PEP 523) now requires a new mandatory
tstate parameter (PyThreadState*).
vstinner requested a review from brettcannon November 16, 2019 00:18

vstinner commented Nov 16, 2019

Copy link
Copy Markdown
Member Author

This change is backward incompatible and changes the PEP 523. I would prefer to have it carefully reviewed ;-)

shihai1991 commented Nov 16, 2019

Copy link
Copy Markdown
Member

This change is backward incompatible and changes the PEP 523. I would prefer to have it carefully reviewed ;-)

In order to keep backward compatibility, can we use a new function to do this action?

vstinner commented Nov 16, 2019

Copy link
Copy Markdown
Member Author

In order to keep backward compatibility, can we use a new function to do this action?

PyInterpreterState.eval_frame is a structure field. What do you mean?

corona10 approved these changes Nov 16, 2019
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@shihai1991

It can happen from the contributors who are not familiar with the codebase.
@shihai1991 I think that the snippet I attach links below will help your future contribution.

cpython/Include/pystate.h

Line 25 in 2bc43cd

typedef struct _is PyInterpreterState;

cpython/Include/internal/pycore_pystate.h

Line 109 in 9def81a

_PyFrameEvalFunction eval_frame;

@vstinner
Looks good to me.

shihai1991 commented Nov 17, 2019

Copy link
Copy Markdown
Member

In order to keep backward compatibility, can we use a new function to do this action?

PyInterpreterState.eval_frame is a structure field. What do you mean?

Sorry, i didn't express cleary. I just worried about whether we have external user use _PyEval_EvalFrameDefault(struct _frame *f, int exc)(although it's a inner function).

vstinner commented Nov 18, 2019

Copy link
Copy Markdown
Member Author

frame_eval is specified by https://www.python.org/dev/peps/pep-0523/

The question if it should be public or not is discussed at https://bugs.python.org/issue38500

At least, the API (frame_eval) is used by PyCharm to implement their debugger ;-)

brettcannon commented Nov 18, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

I don't think this should go in until bpo-38500 is resolved.

vstinner mentioned this pull request Nov 22, 2019
Closed

vstinner commented Mar 10, 2020

Copy link
Copy Markdown
Member Author

I included this change into PR #17340. I close this PR.

vstinner closed this Mar 10, 2020
vstinner deleted the eval_frame_tstate branch March 10, 2020 17:31
vstinner mentioned this pull request Mar 10, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brettcannon brettcannon approved these changes
corona10 corona10 approved these changes

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL