Repository navigation
[3.8] bpo-38707: Fix for multiprocessing.Process MainThread.native_id (GH-17088) - #17261
Merged
miss-islington merged 1 commit intoNov 19, 2019
Merged
miss-islington merged 1 commit into
miss-islington merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…onGH-17088) This PR implements a fix for `multiprocessing.Process` objects; the error occurs when Processes are created using either `fork` or `forkserver` as the `start_method`. In these instances, the `MainThread` of the newly created `Process` object retains all attributes from its parent's `MainThread` object, including the `native_id` attribute. The resulting behavior is such that the new process' `MainThread` captures an incorrect/outdated `native_id` (the parent's instead of its own). This change forces the Process object to update its `native_id` attribute during the bootstrap process. cc @vstinner https://bugs.python.org/issue38707 Automerge-Triggered-By: @pitrou (cherry picked from commit c6b20be) Co-authored-by: Jake Tesler <jake.tesler@gmail.com>
pitrou
approved these changes
Nov 19, 2019
pitrou
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
+1
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@jaketesler: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@jaketesler: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Contributor
Author
|
@jaketesler: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a fix for multiprocessing.Process objects; the error occurs when Processes are created using either fork or forkserver as the start_method.
In these instances, the MainThread of the newly created Process object retains all attributes from its parent's MainThread object, including the native_id attribute. The resulting behavior is such that the new process' MainThread captures an incorrect/outdated native_id (the parent's instead of its own).
This change forces the Process object to update its native_id attribute during the bootstrap process.
cc @vstinner
https://bugs.python.org/issue38707
Automerge-Triggered-By: @pitrou
(cherry picked from commit c6b20be)
Co-authored-by: Jake Tesler jake.tesler@gmail.com
https://bugs.python.org/issue38707
Automerge-Triggered-By: @pitrou