FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-57795: IDLE: Enter the selected text when opening the "Replace" dialog by ZackerySpytz · Pull Request #17593 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-57795: IDLE: Enter the selected text when opening the "Replace" dialog #17593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 3 commits into from
Dec 27, 2023
Conversation 3 Commits 3 Checks 0 Files changed
Merged

gh-57795: IDLE: Enter the selected text when opening the "Replace" dialog #17593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da6e077
bpo-13586: IDLE: Enter the selected text when opening the "Replace" d…
ZackerySpytz Dec 13, 2019
edea4ed
Merge branch 'main' into bpo-13586-idle-replace-select
serhiy-storchaka Dec 27, 2023
0f6b1f5
Resuse the searchphrase parameter of SearchDialogBase.open().
serhiy-storchaka Dec 27, 2023
File filter

Filter by extension

Filter by extension .py  (1) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
23 changes: 7 additions & 16 deletions Lib/idlelib/replace.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ def replace(text, insert_tags=None):
if not hasattr(engine, "_replacedialog"):
engine._replacedialog = ReplaceDialog(root, engine)
dialog = engine._replacedialog
dialog.open(text, insert_tags=insert_tags)
searchphrase = text.get("sel.first", "sel.last")
dialog.open(text, searchphrase, insert_tags=insert_tags)


class ReplaceDialog(SearchDialogBase):
Expand All @@ -51,27 +52,17 @@ def __init__(self, root, engine):
self.replvar = StringVar(root)
self.insert_tags = None

def open(self, text, insert_tags=None):
def open(self, text, searchphrase=None, *, insert_tags=None):
"""Make dialog visible on top of others and ready to use.

Also, highlight the currently selected text and set the
search to include the current selection (self.ok).
Also, set the search to include the current selection
(self.ok).

Args:
text: Text widget being searched.
searchphrase: String phrase to search.
"""
SearchDialogBase.open(self, text)
try:
first = text.index("sel.first")
except TclError:
first = None
try:
last = text.index("sel.last")
except TclError:
last = None
first = first or text.index("insert")
last = last or first
self.show_hit(first, last)
SearchDialogBase.open(self, text, searchphrase)
self.ok = True
self.insert_tags = insert_tags

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/IDLE/2019-12-13-12-26-56.bpo-13586.1grqsR.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Enter the selected text when opening the "Replace" dialog.
Back | FazBrowse Home | New Git URL