Repository navigation
bpo-39264: Fix UserDict.get() to account for __missing__() - #17910
Merged
miss-islington merged 11 commits intoMay 10, 2022
Merged
miss-islington merged 11 commits into
miss-islington merged 11 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Seems like ubuntu's archives are down. |
Sorry, something went wrong.
remilapeyre
reviewed
Jun 15, 2020
Comment thread
Lib/collections/__init__.py
remilapeyre
reviewed
Jun 15, 2020
Comment thread
Misc/NEWS.d/next/Library/2020-01-09-01-57-12.bpo-39264.GsBL9-.rst
Outdated
Comment thread
Lib/collections/__init__.py
Comment thread
Lib/test/test_collections.py
Outdated
Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
rhettinger
approved these changes
Apr 18, 2022
Comment thread
Lib/collections/__init__.py
| if key in self: | ||
| return self[key] | ||
| return default | ||
|
|
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nit: Only one blank line so as to match the surrounding code.
Sorry, something went wrong.
Comment thread
Lib/collections/__init__.py
| def __contains__(self, key): | ||
| return key in self.data | ||
|
|
||
| def get(self, key, default=None): |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Add a comment that get() is overridden to avoid a False positive when _missing_ is defined.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Closing and reopening to trigger the CI bots. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@bharel: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
kenodegard
added a commit
to johnnynunez/conda
that referenced
this pull request
Dec 11, 2023
Python 3.12 no longer calls `UserDict.__missing__`. See python/cpython#17910.
kenodegard
added a commit
to conda/conda
that referenced
this pull request
Dec 12, 2023
Required a fix for fetching aliases from `RepodataState` since Python 3.12 no longer calls `UserDict.__missing__`. See python/cpython#17910. --------- Co-authored-by: Travis Hathaway <travis.j.hathaway@gmail.com> Co-authored-by: Jannis Leidel <jannis@leidel.info> Co-authored-by: Ken Odegard <kodegard@anaconda.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the patch according to the discussion at the Python-Dev mailing list.
UserDict.get() will match dict's behavior and not call __missing__.
https://bugs.python.org/issue39264
Automerge-Triggered-By: GH:rhettinger