FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Documentation fix on code.py by kylepollina · Pull Request #17988 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Documentation fix on code.py - #17988

Merged
tirkarthi merged 2 commits into
python:masterfrom
kylepollina:patch-1
Jan 14, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Documentation fix on code.py#17988
tirkarthi merged 2 commits into
python:masterfrom
kylepollina:patch-1

Conversation

kylepollina commented Jan 13, 2020 •
edited
Loading

Copy link
Copy Markdown

Small change to InteractiveInterpreter.runsource docstring to make it more readable.

Documentation fix on code.py
2d8300a 
Small change to InteractiveInterpreter.runsource doc string to make it more readable.

the-knights-who-say-ni commented Jan 13, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@kylepollina

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

tirkarthi reviewed Jan 13, 2020
View reviewed changes

tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The change looks correct to me. There is also similar sentence at Doc/library/code.rst that can be changed. It would be good if you can also sign the CLA. Thanks.

eamanu approved these changes Jan 14, 2020
View reviewed changes

eamanu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. +1 to @tirkarthi comments :)

Minor docstring edit on code.rst
3dbe482 
Added minor docstring edit to code.rst to make it more readable.

kylepollina commented Jan 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Author

Added similar change to Doc/library/code.rst as well

kylepollina requested a review from tirkarthi January 14, 2020 02:37
tirkarthi approved these changes Jan 14, 2020
View reviewed changes

tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks.

tirkarthi merged commit b4cdb3f into python:master Jan 14, 2020

miss-islington commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

Thanks @kylepollina for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

Thanks @kylepollina for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 14, 2020
Fix documentation in code.py (pythonGH-17988)
8856954 
(cherry picked from commit b4cdb3f)

Co-authored-by: Kyle Pollina <kylepollina@protonmail.com>

bedevere-bot commented Jan 14, 2020

Copy link
Copy Markdown

GH-18001 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 14, 2020
Fix documentation in code.py (pythonGH-17988)
d64d018 
(cherry picked from commit b4cdb3f)

Co-authored-by: Kyle Pollina <kylepollina@protonmail.com>

bedevere-bot commented Jan 14, 2020

Copy link
Copy Markdown

GH-18002 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jan 14, 2020
Fix documentation in code.py (GH-17988)
9f220e4 
(cherry picked from commit b4cdb3f)

Co-authored-by: Kyle Pollina <kylepollina@protonmail.com>
miss-islington added a commit that referenced this pull request Jan 14, 2020
Fix documentation in code.py (GH-17988)
5c08bfe 
(cherry picked from commit b4cdb3f)

Co-authored-by: Kyle Pollina <kylepollina@protonmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Fix documentation in code.py (pythonGH-17988)
c7226b8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tirkarthi tirkarthi approved these changes
+1 more reviewer
eamanu eamanu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL