bpo-39342: Expose X509_V_FLAG_ALLOW_PROXY_CERTS in ssl module - #18011
Merged
miss-islington merged 2 commits intoMar 18, 2021
Merged
bpo-39342: Expose X509_V_FLAG_ALLOW_PROXY_CERTS in ssl module#18011miss-islington merged 2 commits into
miss-islington merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks, your patch looks good to me. I cannot approve the PR at the moment. GH request fails with Personal token required for this feature. I'll look into the matter later. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@tiran Sorry to pester you, but could you take a look when you get a chance? I'm fairly sure Travis CI failed due to a network glitch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I too would like to see this PR be merged. Is there anything I can do to help ? |
Sorry, something went wrong.
chrisburr
force-pushed
the
fix-issue-39342
branch
from
f7b75c1 to
404c317
Compare
October 5, 2020 12:50
chrisburr
force-pushed
the
fix-issue-39342
branch
from
404c317 to
53747c1
Compare
December 9, 2020 13:59
chrisburr
requested review from
1st1,
abalkin,
asvetlov,
berkerpeksag,
brettcannon,
encukou,
ericsnowcurrently,
ericvsmith,
ethanfurman,
ezio-melotti,
gpshead,
gvanrossum,
ilevkivskyi,
lysnikolaou,
markshannon,
methane,
ncoghlan,
pablogsal,
pganssle,
rhettinger,
terryjreedy and
vsajip
as code owners
December 9, 2020 13:59
chrisburr
force-pushed
the
fix-issue-39342
branch
from
c9a602d to
f806eaf
Compare
December 9, 2020 14:02
chrisburr
force-pushed
the
fix-issue-39342
branch
from
f806eaf to
89c354c
Compare
December 9, 2020 14:04
markshannon
removed request for
a team,
ethanfurman,
ezio-melotti,
gvanrossum,
ilevkivskyi,
lysnikolaou,
markshannon,
pablogsal,
rhettinger and
terryjreedy
December 9, 2020 15:08
Copy link
Copy Markdown
Member
|
The bogus review requests and CLA report are likely a result of force-pushing. This should not be be used when git merge origin/master is all that is needed. |
Sorry, something went wrong.
brettcannon
removed their request for review
December 9, 2020 17:37
Copy link
Copy Markdown
Contributor
Author
|
I accidentally rebased on my fork's master instead of python/cpython which seems to have triggered GitHub to automatically request a review from many people. Sorry for the trouble. |
Sorry, something went wrong.
vsajip
removed their request for review
December 14, 2020 10:19
methane
removed their request for review
March 18, 2021 07:17
tiran
approved these changes
Mar 18, 2021
jab
added a commit
to jab/cpython
that referenced
this pull request
Mar 20, 2021
* master: (129 commits) bpo-43452: Micro-optimizations to PyType_Lookup (pythonGH-24804) bpo-43517: Fix false positive in detection of circular imports (python#24895) bpo-43494: Make some minor changes to lnotab notes (pythonGH-24861) Mention that code.co_lnotab is deprecated in what's new for 3.10. (python#24902) bpo-43244: Remove symtable.h header file (pythonGH-24910) bpo-43466: Add --with-openssl-rpath configure option (pythonGH-24820) Fix a typo in c-analyzer (pythonGH-24468) bpo-41561: Add workaround for Ubuntu's custom security level (pythonGH-24915) bpo-43521: Allow ast.unparse with empty sets and NaN (pythonGH-24897) bpo-43244: Remove the PyAST_Validate() function (pythonGH-24911) bpo-43541: Fix PyEval_EvalCodeEx() regression (pythonGH-24918) bpo-43244: Fix test_peg_generators on Windows (pythonGH-24913) bpo-39342: Expose X509_V_FLAG_ALLOW_PROXY_CERTS in ssl module (pythonGH-18011) bpo-43244: Fix test_peg_generator for PyAST_Validate() (pythonGH-24912) bpo-42128: Add 'missing :' syntax error message to match statements (pythonGH-24733) bpo-43244: Add pycore_ast.h header file (pythonGH-24908) bpo-43244: Rename pycore_ast.h to pycore_ast_state.h (pythonGH-24907) Remove unnecessary imports in the grammar parser (pythonGH-24904) bpo-35883: Py_DecodeLocale() escapes invalid Unicode characters (pythonGH-24843) Add PEP 626 to what's new in 3.10. (python#24892) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the X509_V_FLAG_ALLOW_PROXY_CERTS constant as ssl.VERIFY_ALLOW_PROXY_CERTS to allow for proxy certificate validation as described in: https://www.openssl.org/docs/man1.1.1/man7/proxy-certificates.html
https://bugs.python.org/issue39342
Automerge-Triggered-By: GH:tiran