FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-39359, zipfile: add missing "pwd: expected bytes, got str" exception by danifus · Pull Request #18031 · python/cpython · GitHub

Repository navigation

bpo-39359, zipfile: add missing "pwd: expected bytes, got str" exception - #18031

Merged
ambv merged 3 commits into
python:mainfrom
danifus:bpo-39359
Sep 23, 2021
Merged

ambv merged 3 commits into
python:mainfrom
danifus:bpo-39359

Conversation

danifus commented Jan 16, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Setting the ZipFile.pwd attribute directly skips the check to ensure the password is a bytes object and, if not, return a user friendly TypeError("pwd: expected bytes, got ") informing them of that.

https://bugs.python.org/issue39359

ambv commented Sep 23, 2021

Copy link
Copy Markdown
Contributor

Closing and re-opening to re-trigger CI.

ambv closed this Sep 23, 2021
ambv reopened this Sep 23, 2021
ambv merged commit 91099e2 into python:main Sep 23, 2021
danifus deleted the bpo-39359 branch September 23, 2021 22:59

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux Asan 3.x has failed when building commit 91099e2.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/582/builds/572) and take a look at the build logs.
  4. Check if the failure is related to this commit (91099e2) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/582/builds/572

Summary of the results of the build (if available):

Click to see traceback logs
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64.asan/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_bc1c4cf1'


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64.asan/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_b8f1eb56'

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL