FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-39388: IDLE: Fix bug when cancelling out of configdialog by csabella · Pull Request #18068 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-39388: IDLE: Fix bug when cancelling out of configdialog - #18068

Merged
terryjreedy merged 5 commits into
python:masterfrom
csabella:cancelconfig
Jan 25, 2020
ConversationCommits (5)ChecksFiles changed
Merged

bpo-39388: IDLE: Fix bug when cancelling out of configdialog#18068
terryjreedy merged 5 commits into
python:masterfrom
csabella:cancelconfig

Conversation

csabella commented Jan 19, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Changes to keybindings were being remembered even when cancelling out of the Config Dialog.

https://bugs.python.org/issue39388

csabella requested a review from terryjreedy as a code owner January 19, 2020 17:29
csabella changed the title bpo-39388: Fix bug when cancelling out of configdialog bpo-39388: IDLE: Fix bug when cancelling out of configdialog Jan 19, 2020
terryjreedy reviewed Jan 25, 2020
View reviewed changes

terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A 2nd button bug not caught by missing tests. We wrote changes.clear to be called at this spot. (It is not called anywhere else.) I will add a test that changes is cleared and add news items.

terryjreedy added needs backport to 3.7 type-bug An unexpected behavior, bug, or error labels Jan 25, 2020
terryjreedy merged commit d0d9fa8 into python:master Jan 25, 2020

miss-islington commented Jan 25, 2020

Copy link
Copy Markdown
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 25, 2020
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (pythonG…
6cb1d80 
…H-18068)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit d0d9fa8)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>

bedevere-bot commented Jan 25, 2020

Copy link
Copy Markdown

GH-18178 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 25, 2020
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (pythonG…
6065b6e 
…H-18068)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit d0d9fa8)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>

bedevere-bot commented Jan 25, 2020

Copy link
Copy Markdown

GH-18179 is a backport of this pull request to the 3.7 branch.

sthagen added a commit to sthagen/python-cpython that referenced this pull request Jan 25, 2020
Merge pull request #207 from python/master
21dc636 
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (pythonGH-18068)
miss-islington added a commit that referenced this pull request Jan 25, 2020
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068)
a234492 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit d0d9fa8)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Jan 25, 2020
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068)
fd9ce2b 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit d0d9fa8)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>

csabella commented Jan 25, 2020

Copy link
Copy Markdown
Contributor Author

I had some additional test for configdialog in GH-3592 and I rebased it last week. It's not all the missing tests.

csabella deleted the cancelconfig branch January 25, 2020 12:19
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (pythonG…
f837254 
…H-18068)


Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL