FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-75008: guess lineterminator in csv.Sniffer by vmax · Pull Request #18336 · python/cpython · GitHub

Repository navigation

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .py  (2) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
24 changes: 19 additions & 5 deletions Lib/csv.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def writerows(self, rowdicts):

class Sniffer:
'''
"Sniffs" the format of a CSV file (i.e. delimiter, quotechar)
"Sniffs" the format of a CSV file (i.e. delimiter, quotechar, lineterminator)
Returns a Dialect object.
'''
def __init__(self):
Expand All @@ -246,18 +246,19 @@ def sniff(self, sample, delimiters=None):
Returns a dialect (or None) corresponding to the sample
"""

lineterminator = self._guess_lineterminator(sample)
quotechar, doublequote, delimiter, skipinitialspace = \
self._guess_quote_and_delimiter(sample, delimiters)
if not delimiter:
delimiter, skipinitialspace = self._guess_delimiter(sample,
delimiters)
delimiters,
lineterminator)

if not delimiter:
raise Error("Could not determine delimiter")

class dialect(Dialect):
_name = "sniffed"
lineterminator = '\r\n'
quoting = QUOTE_MINIMAL
# escapechar = ''

Expand All @@ -266,6 +267,7 @@ class dialect(Dialect):
# _csv.reader won't accept a quotechar of ''
dialect.quotechar = quotechar or '"'
dialect.skipinitialspace = skipinitialspace
dialect.lineterminator = lineterminator

return dialect

Expand Down Expand Up @@ -346,7 +348,7 @@ def _guess_quote_and_delimiter(self, data, delimiters):
return (quotechar, doublequote, delim, skipinitialspace)


def _guess_delimiter(self, data, delimiters):
def _guess_delimiter(self, data, delimiters, lineterminator):
"""
The delimiter /should/ occur the same number of times on
each row. However, due to malformed data, it may not. We don't want
Expand All @@ -365,7 +367,7 @@ def _guess_delimiter(self, data, delimiters):
additional chunks as necessary.
"""

data = list(filter(None, data.split('\n')))
data = list(filter(None, data.split(lineterminator)))

ascii = [chr(c) for c in range(127)] # 7-bit ASCII

Expand Down Expand Up @@ -511,3 +513,15 @@ def has_header(self, sample):
hasHeader -= 1

return hasHeader > 0


def _guess_lineterminator(self, sample):
# Guess line terminator based on presence
terminators = ('\r\n', '\n', '\r')

for terminator in terminators:
if terminator in sample:
return terminator

from os import linesep
return linesep
15 changes: 15 additions & 0 deletions Lib/test/test_csv.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -1414,6 +1414,21 @@ def test_doublequote(self):
dialect = sniffer.sniff(self.sample9)
self.assertTrue(dialect.doublequote)

def test_guess_lineterminator(self):
from os import linesep
sniffer = csv.Sniffer()
dialect = sniffer.sniff('Date;Value\r\n2010-01-01;10')
self.assertEqual(dialect.lineterminator, '\r\n')
dialect = sniffer.sniff('Date;Value\n2010-01-01;10')
self.assertEqual(dialect.lineterminator, '\n')
dialect = sniffer.sniff('Date;Value\r2010-01-01;10')
self.assertEqual(dialect.lineterminator, '\r')
dialect = sniffer.sniff('Date;Value\v2010-01-01;10')
self.assertEqual(dialect.lineterminator, linesep)
dialect = sniffer.sniff('Date;Value')
self.assertEqual(dialect.lineterminator, linesep)


class NUL:
def write(s, *args):
pass
Expand Down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
:class:`csv.Sniffer` now detects line terminator instead of defaulting to '\r\n'

Back | FazBrowse Home | New Git URL