FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-39593: Adding an unit test of ctypes by shihai1991 · Pull Request #18424 · python/cpython · GitHub

/ cpython Public

bpo-39593: Adding an unit test of ctypes - #18424

Merged
vstinner merged 6 commits into
python:masterfrom
shihai1991:bpo_39593
Jun 1, 2020
ConversationCommits (6)ChecksFiles changed
Merged

bpo-39593: Adding an unit test of ctypes#18424
vstinner merged 6 commits into
python:masterfrom
shihai1991:bpo_39593

Conversation

shihai1991 commented Feb 9, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

shihai1991 mentioned this pull request Feb 9, 2020
Closed

codecov Bot commented Feb 9, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #18424 into master will increase coverage by 0.99%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #18424       +/-   ##
===========================================
+ Coverage   82.19%   83.19%    +0.99%     
===========================================
  Files        1957     1570      -387     
  Lines      589306   414436   -174870     
  Branches    44428    44428               
===========================================
- Hits       484409   344788   -139621     
+ Misses      95235    59998    -35237     
+ Partials     9662     9650       -12
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-12.86%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Lib/dbm/__init__.py 66.66% <0.00%> (-4.45%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.87%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
... and 431 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f6f7ee...f013d98. Read the comment docs.

corona10 reviewed Feb 10, 2020
View reviewed changes
Comment thread Modules/_ctypes/cfield.c
corona10 approved these changes Feb 10, 2020
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM on my side.
@vstinner Can you please take a look?

csabella requested review from vstinner and removed request for vstinner May 25, 2020 17:53
vstinner reviewed May 27, 2020
View reviewed changes
Comment thread Lib/ctypes/test/test_struct_fields.py Outdated

vstinner commented May 27, 2020

Copy link
Copy Markdown
Member

Oops, I had a pending comment that I never submitted!

shihai1991 commented May 27, 2020

Copy link
Copy Markdown
Member Author

Oops, I had a pending comment that I never submitted!

I always forget to submit too ; )

shihai1991 commented May 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

@vstinner Hi, victor. There have a testcase of nomralizeing() in #19069, can you take a look if you have free time, thanks.

vstinner reviewed May 28, 2020
View reviewed changes
Comment thread Modules/_ctypes/cfield.c Outdated

data = PyBytes_AS_STRING(value);
size = strlen(data); /* XXX Why not Py_SIZE(value)? */
/* bpo-39593: XXX Why not Py_SIZE(value)? */

vstinner May 28, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't think that it's correct to add a test which indirectly specify the behavior and keep this comment which suggests to change the behavior.

I suggest to rewrite the comment to explain that we do use strlen() on purpose, rather than PyBytes_GET_SIZE() since we truncate characters after a null character on purpose. Keep the bpo number in the comment.

shihai1991 May 28, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, got it. I updated the description info, do you think it's clear enough?

vstinner reviewed May 28, 2020
View reviewed changes
Comment thread Modules/_ctypes/cfield.c Outdated
Update Modules/_ctypes/cfield.c
bc3b678 
Co-authored-by: Victor Stinner <vstinner@python.org>
shihai1991 requested a review from vstinner June 1, 2020 16:32
vstinner merged commit a97011b into python:master Jun 1, 2020

vstinner commented Jun 1, 2020

Copy link
Copy Markdown
Member

Thanks, merged.

shihai1991 commented Jun 1, 2020

Copy link
Copy Markdown
Member Author

Thanks, merged.

Thanks, victor.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 approved these changes
vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL