[WIP] bpo-35134: Move header files to Include/cpython/ - #18490
Closed
vstinner wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The whole content of cellobject.h, classobject.h, genobject.h, pyarena.h, pyctype.h, pydebug.h, pyfpe.h and pytime.h is excluded from the limited C API, so move these header files to Include/cpython/ directory. Since they are included by the main Python.h: users should not be affected by this change. If one of these header file is included explicitly: only include Python.h instead.
vstinner
requested review from
1st1,
abalkin,
pablogsal and
pganssle
as code owners
February 12, 2020 21:26
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #18490 +/- ##
=========================================
Coverage 82.11% 82.12%
=========================================
Files 1956 1955 -1
Lines 589183 583854 -5329
Branches 44448 44449 +1
=========================================
- Hits 483833 479488 -4345
+ Misses 95701 94722 -979
+ Partials 9649 9644 -5
Continue to review full report at Codecov.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This change break C extension modules which explicitly include on these moved header files. A safer approach would be to keep .h files in Include/ but move their content into a new Include/cpython/ file. I close this PR. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whole cellobject.h API is excluded from the limited C API, so
move the header file to Include/cpython/ directory. Since
cellobject.h is included by the main Python.h: users should not be
affected by this change.
https://bugs.python.org/issue35134