FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic by shihai1991 · Pull Request #18512 · python/cpython · GitHub

/ cpython Public

gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic - #18512

Closed
shihai1991 wants to merge 2 commits into
python:mainfrom
shihai1991:bpo_20184
ConversationCommits (2)ChecksFiles changed
Closed

gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic#18512
shihai1991 wants to merge 2 commits into
python:mainfrom
shihai1991:bpo_20184

Conversation

shihai1991 commented Feb 15, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

shihai1991 requested a review from ncoghlan February 15, 2020 10:23

codecov Bot commented Feb 15, 2020

Copy link
Copy Markdown

Codecov Report

Merging #18512 into master will increase coverage by 3.73%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #18512       +/-   ##
===========================================
+ Coverage   79.46%   83.20%    +3.73%     
===========================================
  Files         384     1571     +1187     
  Lines      169290   414730   +245440     
  Branches        0    44456    +44456     
===========================================
+ Hits       134529   345067   +210538     
- Misses      34761    60020    +25259     
- Partials        0     9643     +9643
Impacted Files Coverage Δ
Python/dynload_shlib.c
Parser/parsetok.c
Python/marshal.c
Python/hamt.c
Python/clinic/sysmodule.c.h
Objects/bytes_methods.c
Modules/_hashopenssl.c
Modules/_ctypes/callbacks.c
Modules/cjkcodecs/cjkcodecs.h
Objects/capsule.c
... and 1943 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f632736...3b315ef. Read the comment docs.

JelleZijlstra commented Apr 17, 2022

Copy link
Copy Markdown
Member

Sorry this had to wait for so long! If you're still interested, would you be able to fix the merge conflicts? Then I can review it and get it merged.

shihai1991 commented Apr 19, 2022

Copy link
Copy Markdown
Member Author

Sorry this had to wait for so long! If you're still interested, would you be able to fix the merge conflicts? Then I can review it and get it merged.

Oh, Thanks. Give me some time to take a look. I forget the details already :(

hauntsaninja requested changes Feb 9, 2023
View reviewed changes

hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Requesting changes for fixing the conflicts, as per above

bedevere-bot commented Feb 9, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

arhadthedev changed the title bpo-20184: Migrate builtins.vars and builtins.dir to Argument Clinic gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic Feb 13, 2023
arhadthedev added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Feb 13, 2023

arhadthedev commented Feb 13, 2023

Copy link
Copy Markdown
Member

Superseded by gh-100358.

larryhastings mentioned this pull request Feb 13, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hauntsaninja hauntsaninja requested changes
ncoghlan Awaiting requested review from ncoghlan
larryhastings Awaiting requested review from larryhastings

Assignees

No one assigned

Labels

awaiting changes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-argument-clinic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL