FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.7] bpo-27657: Revert - Fix urlparse() with numeric paths (GH-661)" by orsenthil · Pull Request #18526 · python/cpython · GitHub

/ cpython Public

[3.7] bpo-27657: Revert - Fix urlparse() with numeric paths (GH-661)" - #18526

Merged
orsenthil merged 1 commit into
python:3.7from
orsenthil:issue27657-3.7-revert
Feb 16, 2020
ConversationCommits (1)ChecksFiles changed
Merged

[3.7] bpo-27657: Revert - Fix urlparse() with numeric paths (GH-661)"#18526
orsenthil merged 1 commit into
python:3.7from
orsenthil:issue27657-3.7-revert

Conversation

orsenthil commented Feb 16, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member 
[bpo-27657](https://bugs.python.org/issue27657): Revert - Fix urlparse() with numeric paths (GH-661)

This reverts commit 82b5f6b.

The change broke the backward compatibility of parsing behavior in a
patch release of Python (3.7.6). A decision was taken to revert this
patch in 3.7.7.

In https://bugs.python.org/issue27657 it was decided that the previous
behavior like

urlparse('localhost:8080')
ParseResult(scheme='', netloc='', path='localhost:8080', params='', query='', fragment='')

urlparse('undefined:8080')
ParseResult(scheme='', netloc='', path='undefined:8080', params='', query='', fragment='')

needs to be preserved in patch releases as users rely upon it.

https://bugs.python.org/issue27657

orsenthil requested a review from ned-deily February 16, 2020 18:19
ned-deily requested changes Feb 16, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2020-02-16-07-47-55.bpo-27657.9kZchc.rst Outdated

ned-deily Feb 16, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we should explicitly mention the releases involved. For 3.7, how about something like:

The original fix for bpo-27657, "Fix urlparse() with numeric paths" (GH-16839)
included in 3.7.6, inadvertently introduced a behavior change that broke several third-party packages relying on the original undefined parsing behavior. The change is reverted in 3.7.7, restoring the behavior of 3.7.5 and earlier releases.

orsenthil Feb 16, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, Ned. I have adopted this suggestion.

bedevere-bot commented Feb 16, 2020

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Revert "bpo-27657: Fix urlparse() with numeric paths (GH-661)"
c703e5d 
This reverts commit 82b5f6b.

The change broke the backwards compatibility of parsing behavior in a
patch release of Python (3.7.6). A decision was taken to revert this
patch in 3.7.7.

In https://bugs.python.org/issue27657 it was decided that the previous
behavior like

>>> urlparse('localhost:8080')
ParseResult(scheme='', netloc='', path='localhost:8080', params='', query='', fragment='')

>>> urlparse('undefined:8080')
ParseResult(scheme='', netloc='', path='undefined:8080', params='', query='', fragment='')

needs to be preserved in patch releases as number of users rely upon it.

Explicitly mention the releases involved with the revert in NEWS.
Adopt the wording suggested by @ned-deily.

orsenthil commented Feb 16, 2020

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

bedevere-bot commented Feb 16, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

ned-deily approved these changes Feb 16, 2020
View reviewed changes

ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks, Senthil!

orsenthil merged commit 505b601 into python:3.7 Feb 16, 2020

bedevere-bot commented Feb 16, 2020

Copy link
Copy Markdown

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ned-deily ned-deily approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL