bpo-17422:language reference should specify restrictions on class namespace by ananthan-123 · Pull Request #18559 · python/cpython · GitHub

https://bugs.python.org/issue17422

Thanks @ananthan-123. No need to request reviews from 3 triagers and 4 core developers though, that's bordering on spam (especially if they have nothing to do with the issue/patch). One request should be fine, maybe a second if the first person doesn't respond after a week or two.

A few things I spotted here (I'm assuming that the wording in Eric's original patch from 7 years ago is correct):

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>

…7_9zz.rst Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>

Looks good now. @ericsnowcurrently, care to review the content for this? It's your issue.

Sorry, one more thing...

…7_9zz.rst Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>

Please attribute the patch to its author here.

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

Thanks @ananthan-123 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

Thanks @ananthan-123 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

GH-18610 is a backport of this pull request to the 3.8 branch.

…mespace (pythonGH-18559) The language reference now specifies restrictions on class namespaces. Adapted from a patch by Ethan Furman. (cherry picked from commit fbe2e0b) Co-authored-by: ananthan-123 <ananthakrishnan15.2001@gmail.com>

GH-18611 is a backport of this pull request to the 3.7 branch.

…mespace (GH-18559) The language reference now specifies restrictions on class namespaces. Adapted from a patch by Ethan Furman. (cherry picked from commit fbe2e0b) Co-authored-by: ananthan-123 <ananthakrishnan15.2001@gmail.com>

Per PEP 520, the default class namespace must be an ordered mapping and the original text here was purposefully phrased. While we've talked about requiring "dict" to be ordered (in the language reference), that hasn't happened. So changing the language spec text here to "dict" is inappropriate without a PEP. Note that elsewhere in the language reference the "ordered mapping" phrasing still exists.

Um, dict is required to be ordered. Since 3.7. See the 3.7. what's new doc "the insertion-order preservation nature of dict objects has been declared to be an official part of the Python language spec."

If after that has sunk in you still think this PR is wrong, please submit a new PR to fix it! (Sorry for landing prematurely.)

Per my comment on the bpo I think @ericsnowcurrently is right but for the wrong reasons. I have opened a PR correcting the wording. #18682

language reference should specify restrictions on class namespace

67042fc

the-knights-who-say-ni added the CLA signed label Feb 19, 2020

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 19, 2020

ananthan-123 requested a review from ericsnowcurrently February 19, 2020 11:11

📜🤖 Added by blurb_it.

3cc613c

ananthan-123 requested review from corona10 and mdickinson February 19, 2020 11:14

Update 2020-02-19-11-13-47.bpo-17422 .g7_9zz.rst

5344bd5

ananthan-123 requested a review from gvanrossum February 19, 2020 15:59

mdickinson removed their request for review February 19, 2020 18:27

ananthan-123 requested review from ammaraskar, brandtbucher and rhettinger February 21, 2020 09:01

brandtbucher removed request for ammaraskar, corona10, gvanrossum and rhettinger February 21, 2020 15:24

brandtbucher requested changes Feb 21, 2020

View reviewed changes

Comment thread Doc/reference/datamodel.rst

Comment thread Doc/reference/datamodel.rst Outdated

Comment thread Doc/reference/datamodel.rst

Comment thread Misc/NEWS.d/next/Documentation/2020-02-19-11-13-47.bpo-17422.g7_9zz.rst Outdated

bedevere-bot added awaiting core review and removed awaiting review labels Feb 21, 2020

ananthan-123 and others added 8 commits February 21, 2020 21:37

Update datamodel.rst

ce1211d

Update datamodel.rst

50bf96c

Update datamodel.rst

fe0e189

Update Doc/reference/datamodel.rst

0cbefbd

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>

Update Misc/NEWS.d/next/Documentation/2020-02-19-11-13-47.bpo-17422 .g…

8ff956a

…7_9zz.rst Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>

Update datamodel.rst

1d37fb2

Update datamodel.rst

c0d6251

Update datamodel.rst

9823caa

ananthan-123 requested a review from brandtbucher February 21, 2020 16:27

brandtbucher approved these changes Feb 21, 2020

View reviewed changes

brandtbucher requested changes Feb 21, 2020

View reviewed changes

Comment thread Misc/NEWS.d/next/Documentation/2020-02-19-11-13-47.bpo-17422.g7_9zz.rst Outdated

Update Misc/NEWS.d/next/Documentation/2020-02-19-11-13-47.bpo-17422 .g…

1c648cd

…7_9zz.rst Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>

brandtbucher approved these changes Feb 22, 2020

View reviewed changes

gvanrossum approved these changes Feb 22, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Feb 22, 2020

gvanrossum merged commit fbe2e0b into python:master Feb 22, 2020

bedevere-bot removed the awaiting merge label Feb 22, 2020

gvanrossum added needs backport to 3.7 labels Feb 22, 2020

bedevere-bot removed the needs backport to 3.8 label Feb 22, 2020

bedevere-bot removed the needs backport to 3.7 label Feb 22, 2020

ericsnowcurrently reviewed Feb 28, 2020

View reviewed changes

		@@ -0,0 +1 @@
		Language reference should specify restrictions on class namespace.

+              the final class object is created the namespace is copied into a new ``dict``.
               If the metaclass has no ``__prepare__`` attribute, then the class namespace
-              is initialised as an empty ordered mapping.

bpo-17422:language reference should specify restrictions on class namespace by ananthan-123 · Pull Request #18559 · python/cpython · GitHub

Repository navigation

bpo-17422:language reference should specify restrictions on class namespace - #18559

bpo-17422:language reference should specify restrictions on class namespace#18559gvanrossum merged 12 commits intopython:masterpython/cpython:masterfrom ananthan-123:namespaceCopy head branch name to clipboard

Conversation

ananthan-123 commented Feb 19, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brandtbucher left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gvanrossum Feb 20, 2020

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Feb 22, 2020

Uh oh!

miss-islington commented Feb 22, 2020

Uh oh!

miss-islington commented Feb 22, 2020

Uh oh!

bedevere-bot commented Feb 22, 2020

Uh oh!

bedevere-bot commented Feb 22, 2020

Uh oh!

ericsnowcurrently Feb 28, 2020

Choose a reason for hiding this comment

Uh oh!

gvanrossum Feb 28, 2020

Choose a reason for hiding this comment

Uh oh!

cdonovick Feb 28, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bpo-17422:language reference should specify restrictions on class namespace#18559
gvanrossum merged 12 commits into
python:masterfrom
ananthan-123:namespace

ananthan-123 commented Feb 19, 2020 •
edited by bedevere-bot
Loading

brandtbucher left a comment •
edited
Loading