FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-39757: Use IDNA to encode domain part in email address by Julien00859 · Pull Request #18667 · python/cpython · GitHub

/ cpython Public

bpo-39757: Use IDNA to encode domain part in email address #18667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Julien00859 wants to merge 2 commits into from
Conversation 3 Commits 2 Checks 0 Files changed
Closed

bpo-39757: Use IDNA to encode domain part in email address #18667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dccf01a
bpo-39757: Use IDNA to encode domain part in email address
Julien00859 Feb 26, 2020
12d60ed
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 27, 2020
File filter

Filter by extension

Filter by extension .py  (2) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
4 changes: 3 additions & 1 deletion Lib/email/_header_value_parser.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -497,8 +497,10 @@ class Domain(TokenList):

@property
def domain(self):
return ''.join(super().value.split())
return ''.join(super().value.split()).encode('idna').decode('ascii')

def __str__(self):
return super().__str__().encode('idna').decode('ascii')

class DotAtom(TokenList):
token_type = 'dot-atom'
Expand Down
32 changes: 32 additions & 0 deletions Lib/test/test_email/test_generator.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,38 @@ def test_cte_type_7bit_transforms_8bit_cte(self):
g.flatten(msg)
self.assertEqual(s.getvalue(), expected)

def test_unicode_domain_transforms_idna(self):
msg = EmailMessage()
msg['From'] = "john@examplé.com"
msg['To'] = "Joe <joe@examplé.com>"

expected = textwrap.dedent("""\
From: john@xn--exampl-gva.com
To: Joe <joe@xn--exampl-gva.com>

""").encode('ascii').replace(b'\n', b'\r\n')

s = io.BytesIO()
g = BytesGenerator(s, policy=policy.SMTP)
g.flatten(msg)
self.assertEqual(s.getvalue(), expected)

def test_unicode_domain_transforms_idna_smtputf8_policy(self):
msg = EmailMessage()
msg['From'] = "john@examplé.com"
msg['To'] = "Joe <joe@examplé.com>"

expected = textwrap.dedent("""\
From: john@xn--exampl-gva.com
To: Joe <joe@xn--exampl-gva.com>

""").encode('utf-8').replace(b'\n', b'\r\n')

s = io.BytesIO()
g = BytesGenerator(s, policy=policy.SMTPUTF8)
g.flatten(msg)
self.assertEqual(s.getvalue(), expected)

def test_smtputf8_policy(self):
msg = EmailMessage()
msg['From'] = "Páolo <főo@bar.com>"
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2020-02-27-11-31-12.bpo-39757.FC-lgv.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add IDNA support in email addresses in email.message.EmailMessage
Back | FazBrowse Home | New Git URL