FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[WIP] bpo-1294959: setup.py uses sys.platlibdir by vstinner · Pull Request #18917 · python/cpython · GitHub

Repository navigation

[WIP] bpo-1294959: setup.py uses sys.platlibdir - #18917

Closed
vstinner wants to merge 1 commit into
python:masterfrom
vstinner:setup_lib64
Closed

vstinner wants to merge 1 commit into
python:masterfrom
vstinner:setup_lib64

Conversation

vstinner commented Mar 11, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

setup.py now uses sys.platlibdir to configure the compiler library
directories and to locate the termcap library.

https://bugs.python.org/issue1294959

setup.py now uses sys.platlibdir to configure the compiler library
directories and to locate the termcap library.

Copy link
Copy Markdown
Member Author

This is the last part of Fedora downstream patch which was part of the commit 8510f43 (PR #18381):
https://src.fedoraproject.org/rpms/python39/blob/master/f/00102-lib64.patch

Copy link
Copy Markdown
Member Author

I have questions.

  • Do we really need this change?
  • Who install libraries in /usr/local? Fedora packages should only install libraries in /usr, not /usr/local. Is it a convenient change for users who install modified or more recent libraries in /usr/local?
  • Why only termcap requires a special change? Is it because termcap library is installed in a subdirectory (/usr/lib/termcap, not "simply" /usr/lib)

Copy link
Copy Markdown
Member Author

@hroncok ran rpmdiff to compare the Fedora with the old downstream patches and with the new upstream commit 8510f43: compare the Python package with and without setup.py changes.

https://src.fedoraproject.org/rpms/python39/pull-request/31#comment-39392

In short, there is no difference. Moreover, @hroncok, @mcepl and me don't know the rationale of these setup.py changes.

I propose to drop them and wait until someone complains. If someone complains, we would know the rationale and so have a good reason to have these setup.py changes.

For readline: Fedora libreadline is already linked to libtinfo and so setup.py doesn't go up to self.compiler.find_library_file(self.lib_dirs + ['/usr/lib/termcap'], 'termcap') code path. This code is deadcode on Fedora.

For /usr/local/lib vs /usr/local/lib64: I'm not sure why /usr/local/lib is used in the first place. Fedora installs libraries in /usr, not in /usr/local. Maybe it's there for users who install dependencies without Fedora: by installed them manually in /usr/local. Again, since it's unclear how /usr/local is supposed to be used, I prefer to leave it unchanged.

I close this issue.

vstinner closed this Mar 13, 2020
vstinner deleted the setup_lib64 branch March 13, 2020 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL