Repository navigation
bpo-39915: Ensure await_args_list is updated according to the order in which coroutines were awaited - #18924
Merged
cjw296 merged 2 commits intoMar 11, 2020
Merged
bpo-39915: Ensure await_args_list is updated according to the order in which coroutines were awaited#18924cjw296 merged 2 commits into
cjw296 merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… which has only last call value.
cjw296
approved these changes
Mar 11, 2020
cjw296
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @tirkarthi for the PR, and @cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 11, 2020
…n which coroutines were awaited (pythonGH-18924) Create call objects with awaited arguments instead of using call_args which has only last call value. (cherry picked from commit e553f20) Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
Copy link
Copy Markdown
|
GH-18927 is a backport of this pull request to the 3.8 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
await_args_list should be updated with the arguments with which the mock was awaited instead of using call_args which has the last call object.
https://bugs.python.org/issue39915