FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-36144: Simplify defaultdict.__or__ by brandtbucher · Pull Request #18931 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-36144: Simplify defaultdict.__or__ - #18931

Merged
gvanrossum merged 1 commit into
python:masterfrom
brandtbucher:patch-1
Mar 12, 2020
ConversationCommits (1)ChecksFiles changed
Merged

bpo-36144: Simplify defaultdict.__or__#18931
gvanrossum merged 1 commit into
python:masterfrom
brandtbucher:patch-1

Conversation

brandtbucher commented Mar 11, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Just something I noticed after #18729 was merged.

https://bugs.python.org/issue36144

brandtbucher added skip news performance Performance or resource usage labels Mar 11, 2020

brandtbucher commented Mar 11, 2020

Copy link
Copy Markdown
Member Author

Closing and reopening since Azure is stalled.

brandtbucher reopened this Mar 11, 2020
gvanrossum reviewed Mar 12, 2020
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Heh, clever. This guarantees that no errors will happen. I think it means that it ignores __instancecheck__. Do you think that's okay? I don't see a great problem with it but want to make sure you've thought about it.

brandtbucher commented Mar 12, 2020

Copy link
Copy Markdown
Member Author

Yeah. I don’t think it’s an issue, since defaultdict doesn’t define __instancecheck__.

gvanrossum commented Mar 12, 2020

Copy link
Copy Markdown
Member

Okay. A subclass could. But I agree it's extremely unlikely. So I'll approve and merge.

gvanrossum merged commit 1dd3794 into python:master Mar 12, 2020

bedevere-bot commented Mar 12, 2020

Copy link
Copy Markdown

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

brandtbucher deleted the patch-1 branch July 21, 2022 20:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

performance Performance or resource usage skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL