Repository navigation
bpo-39943: Remove unused arg from find_nfc_index() - #18973
Merged
vstinner merged 1 commit intoMar 17, 2020
Merged
vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
corona10
approved these changes
Mar 17, 2020
Copy link
Copy Markdown
Contributor
Author
|
Thanks. I used GCC's -Wunused-parameter option and waded through all the false positives. It would be nice if we could have -Wunused-parameter on by default, but there are so many API methods that pass unnecessary parameters, it would make too much noise. Either that, or we'd have to mark every unused parameter with Py_UNUSED, but that would be pretty ugly. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for merging this, @vstinner. Now I can refork my repo to get rid of whatever weird commits I have that caused problems before. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused arg from find_nfc_index()
https://bugs.python.org/issue39943