Repository navigation
bpo-30537: use PyNumber in itertools.islice instead of PyLong - #1918
rhettinger merged 3 commits into
Conversation
Sorry, something went wrong.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
Sorry, something went wrong.
|
Request re-check of CLA (I have signed and should be verified) |
Sorry, something went wrong.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Needed tests and an entry in Misc/NEWS.
Sorry, something went wrong.
| if (robj != Py_None) { | ||
| if (!PyLong_Check(robj)) { | ||
| PyErr_SetString(PyExc_TypeError, "Expected int as r"); | ||
| if (!PyNumber_Check(robj)) { |
There was a problem hiding this comment.
Use PyIndex_Check.
Sorry, something went wrong.
Taking a stab at addressing bpo-30537; replace PyLong_AsSsize_t in itertools with PyNumber_AsSsize_t.