FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-39943: Keep constness of pointers. by petdance · Pull Request #19210 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-39943: Keep constness of pointers. - #19210

Closed
petdance wants to merge 1 commit into
python:masterfrom
petdance:cast-Python-marshal
ConversationCommits (1)ChecksFiles changed
Closed

bpo-39943: Keep constness of pointers.#19210
petdance wants to merge 1 commit into
python:masterfrom
petdance:cast-Python-marshal

Conversation

petdance commented Mar 28, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor 
Make two pointers be const char *.  This quiets a warning from
-Wincompatible-pointer-types.

https://bugs.python.org/issue39943

Keep constness of pointers.
d2d9fca 
Make two pointers be const char *.  This quiets a warning from
-Wincompatible-pointer-types.
petdance requested a review from tiran as a code owner March 28, 2020 17:50

serhiy-storchaka commented Mar 30, 2020

Copy link
Copy Markdown
Member

You can add const to WFILE.end, RFILE.ptr and RFILE.end.

petdance commented Mar 30, 2020

Copy link
Copy Markdown
Contributor Author

You can add const to WFILE.end, RFILE.ptr and RFILE.end.

I'm glad to do that. I was trying to keep changes minimal, but I'll resubmit.

serhiy-storchaka mentioned this pull request Mar 30, 2020
Merged
serhiy-storchaka reviewed Mar 30, 2020
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I have done more cleanup in #19236.

Comment thread Python/marshal.c
if (wf.str != NULL) {
char *base = PyBytes_AS_STRING((PyBytesObject *)wf.str);
const char *base = PyBytes_AS_STRING((PyBytesObject *)wf.str);
if (wf.ptr - base > PY_SSIZE_T_MAX) {

serhiy-storchaka Mar 30, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It seems to me, that this condition is always false (see w_reserve()). So you can remove it.

Comment thread Python/marshal.c
w_object(x, &wf);
w_clear_refs(&wf);
if (wf.str != NULL) {
char *base = PyBytes_AS_STRING((PyBytesObject *)wf.str);

serhiy-storchaka Mar 30, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

AFAIK the cast to PyBytesObject * is not needed.

petdance deleted the cast-Python-marshal branch April 3, 2020 03:03
petdance mannequin mentioned this pull request May 30, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka left review comments
tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL