FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit by BenjaminLiuPenrose · Pull Request #19326 · python/cpython · GitHub

/ cpython Public

bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit - #19326

Closed
BenjaminLiuPenrose wants to merge 2 commits into
python:mainfrom
BenjaminLiuPenrose:my_change
ConversationCommits (2)ChecksFiles changed
Closed

bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit #19326
BenjaminLiuPenrose wants to merge 2 commits into
python:mainfrom
BenjaminLiuPenrose:my_change

Conversation

BenjaminLiuPenrose commented Apr 3, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown

Reference Issues/PRs

bpo-40167 https://bugs.python.org/issue40167
fixes cython project issue in cython/cython#3405

What does this implement/fix? Explain your changes.

fix Cython files don't compile on Mingw-w64 64-bit problem

https://bugs.python.org/issue40167

BenjaminLiuPenrose requested a review from a team as a code owner April 3, 2020 03:00

the-knights-who-say-ni commented Apr 3, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@BenjaminLiuPenrose

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

BenjaminLiuPenrose changed the title Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit bpo-40167 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit Apr 3, 2020

BenjaminLiuPenrose commented Apr 4, 2020

Copy link
Copy Markdown
Author

Hi, I already signed CLA with my github account

taleinat requested changes Sep 26, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Windows/2020-01-24-09-15-41.bpo-8901.hVnhGO.rst
Comment on lines +2 to +3
Add Mingw-w64 64-bit windows machine, fix issue
in https://bugs.python.org/issue40167

taleinat Sep 26, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You'll need to create a new NEWS entry file rather than adding this to an existing one. Use blurb-it or blurb.

Comment thread PC/pyconfig.h


/* Compiler specific defines */
#ifdef __MINGW32__

taleinat Sep 26, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please add a comment explaining why and when this is needed.

bedevere-bot commented Sep 26, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

iritkatriel changed the title bpo-40167 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit Oct 20, 2021

iritkatriel commented Oct 20, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Closed bpo-40167 as a duplicate of an older bpo-35037 which has more info. Please update the PR as requested by @taleinat

imba-tjd mentioned this pull request Jan 27, 2022
Closed
1 task

jimboyeah commented Apr 7, 2022

Copy link
Copy Markdown

You should specify -DMS_WIN64 for g++ to using MinGW-64 on Windows.

1 similar comment

jimboyeah commented Apr 7, 2022

Copy link
Copy Markdown

You should specify -DMS_WIN64 for g++ to using MinGW-64 on Windows.

taleinat commented Apr 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

The original author hasn't picked this up again since my comments 1.5 years ago. I think we can consider them no longer interested.

Is anyone else interested in bringing this to completion? @jimboyeah?

scoder mentioned this pull request Aug 5, 2022
Open
GalaxySnail mentioned this pull request Dec 9, 2022
Merged

rgommers commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

This PR can be closed, it was superceded by gh-100137 which was merged 2 months ago.

arhadthedev commented Feb 15, 2023

Copy link
Copy Markdown
Member

@rgommers Thank you for pointing the duplicate out! Closing.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

taleinat taleinat requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL