@CuriousLearner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @serhiy-storchaka, @ncoghlan and @tiran to be potential reviewers.

Please fix all similar issues.

@serhiy-storchaka sure, on it.

@serhiy-storchaka in the linkchecker/output.txt there were many redirection to /latest urls. Should I remove those changes all together? since I've introduced some of them in this PR.

If the web-server returns the HTTP code in the range 3XX except 301 (Moved Permanently) or 308 (Permanent Redirect), we should keep the original link. For www.pypa.io the code 302 (Found) is returned.

I think it is better to remove all additions of /en/latest/ if the stripped links are working.

Hi @serhiy-storchaka!

I've tried to resolve all the issues with redirection of links.

However I've a concern:
- All the links pointing to github (that are build automatically) are permanently redirected from https://github.com/python/cpython/tree/master/* to https://github.com/python/cpython/blob/master/*

Should we fix these in this PR?

Should we fix these in this PR?

Not in this PR. If there are reasons for using */blob/* liinks, this should be made in a tool that automatically generates links.

Hi @serhiy-storchaka I've done the changes. Also, for the other half, I've tried to do similar changes. Can you please have a look now?

@serhiy-storchaka Can you please take a look here once?

Hey @serhiy-storchaka ,

Just wanted to ping you to know if it would be possible for you to take a look here once.

Thanks :)

@CuriousLearner and @serhiy-storchaka, does this pull request aim to fix only link redirections, as the title says? Because in your first message you wrote: "This is a Work in Progress PR to address link fixes in documentation", and also bpo-25910 is focusing on Fixing links in documentation, so the goal is not clear to me. I am asking because if this PR wants to fix all documentation links, than we have to close #2765 .

I've just run make linkcheck again to check more issues like this. I will update the PR once that is done. :)

I found the following *.readthedocs.org links that still exist that should probably be changed to *.readthedocs.io:

./Doc/library/ast.rst:264:    `Green Tree Snakes <https://greentreesnakes.readthedocs.org/>`_, an external documentation resource, has good
./Doc/library/unittest.mock-examples.rst:1254:<https://pyhamcrest.readthedocs.org/>`_ provides similar functionality,
./Doc/whatsnew/2.5.rst:333:   https://pylib.readthedocs.org/

I suggest this based on the fact that:

• *.readthedocs.org links redirect to *.readthedocs.io (can save a redirect)
• *.readthedocs.io is preferred by Read the docs for cookie security concerns

For additional details, see:

https://blog.readthedocs.com/securing-subdomains/

Starting today, Read the Docs will start hosting projects from subdomains on the domain readthedocs.io, instead of on readthedocs.org. This change addresses some security concerns around site cookies while hosting user generated data on the same domain as our dashboard.

I also found the following links that should be updated to use https.

./Doc/library/string.rst:666:`flufl.i18n <http://flufli18n.readthedocs.io/en/latest/>`_ package.
./Doc/library/smtpd.rst:18:    The `aiosmtpd <http://aiosmtpd.readthedocs.io/>`_ package is a recommended
./Doc/using/mac.rst:69::program:`Gvim` (http://macvim-dev.github.io/macvim/) and :program:`Aquamacs`

Thanks for your inputs @jdufresne . I've fixed those things in 3cd462

@vstinner I'm not sure about this change:

faq/general.rst:56: [redirected permanently] https://www.python.org/psf/license/ to https://docs.python.org/3/license.html

Apart from that, there are several redirection from https://packaging.python.org/installing/ to https://packaging.python.org/tutorials/installing-packages/ Should they be also fixed?

Note: I've left the redirections for Github links; for which I'll file a separate PR.

Hey @vstinner

"FYI I copied/pasted each time manually to open them in Firefox, it took me "forever" to check all these links..."

I really appreciate all the efforts you've put in to review this PR. Thank a lot. I've addressed the reviews, and now I think it would take a lot less time to review.

Also, please see this query: #1933 (comment)

@vstinner I'm not sure about this change: faq/general.rst:56: [redirected permanently] https://www.python.org/psf/license/ to https://docs.python.org/3/license.html

In case of doubt, do nothing. I see that you kept https://www.python.org/psf/license/ : good.

Thanks @CuriousLearner for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

Sorry, @CuriousLearner and @vstinner, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 338cd83c5dceaed785f5bf613e2122f871908e2a 3.6

I don't think that it's worth it to backport this change to Python 3.6 (I missed the "need 3.6 backport" label when I merged this PR).

I merged your PR @CuriousLearner, thanks.

Thanks a lot @vstinner :)