| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@corona10 self.memo of PyScannerObject should be traversed too, right? |
Sorry, something went wrong.
|
@pablogsal: Oh, that's an intersting bug. I consider that it should be backported to 3.7 and 3.8. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM.
@pablogsal: Do you think that a NEWS entry is required for such fix?
Sorry, something went wrong.
Yes, as this may fix much more things that just a memory leak. If (unlikely) the memo gets into a ref cycle, some arbitrary set of objects may not be identified as a cycle and the leak will be considerable. This is a user-visible change: a potential leak that they may be experimenting should be no more, being the leak potentially unbounded. And yes, it should be backported. |
Sorry, something went wrong.
There was a problem hiding this comment.
self.memo of PyScannerObject should be traversed too, right?
Nice catch it should be LGTM
Sorry, something went wrong.
|
Thanks @shihai1991 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
Sorry, something went wrong.
|
Sorry, @shihai1991 and @vstinner, I could not cleanly backport this to 3.8 due to a conflict. |
Sorry, something went wrong.
|
Sorry @shihai1991 and @vstinner, I had trouble checking out the 3.7 backport branch. |
Sorry, something went wrong.
|
Thanks @shihai1991 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Sorry, something went wrong.
|
Sorry, @shihai1991 and @vstinner, I could not cleanly backport this to 3.8 due to a conflict. |
Sorry, something went wrong.
|
@shihai1991: @miss-islington failed to backport automatically the change, there is merge conflict. You can please backport the fix 3.7 and 3.8? You can use cherry_picker or git cherry-pick -x b709302f3125622986bd458dfb2954fda5e8366d. Tell me if you need help for the backport. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
https://bugs.python.org/issue40077