Repository navigation
bpo-40185: Refactor typing.NamedTuple - #19371
Merged
serhiy-storchaka merged 3 commits intoApr 8, 2020
Merged
serhiy-storchaka merged 3 commits into
serhiy-storchaka merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
serhiy-storchaka
requested review from
gvanrossum and
ilevkivskyi
as code owners
April 4, 2020 21:12
ilevkivskyi
approved these changes
Apr 4, 2020
ilevkivskyi
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I like this change, because people sometimes erroneously percept NamedTuple as a "normal" class. I would however double-check with Guido if he is also OK with this.
Sorry, something went wrong.
Comment thread
Lib/test/test_typing.py
| pass | ||
| with self.assertRaises(TypeError): | ||
| class X(NamedTuple, A): | ||
| x: int |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks like a bad merge/rebase, you already added this test in a different PR.
Sorry, something went wrong.
gvanrossum
approved these changes
Apr 7, 2020
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
A work of art!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks. 😊 |
Sorry, something went wrong.
juliusgeo
added a commit
to juliusgeo/cpython
that referenced
this pull request
Mar 4, 2022
This reverts commit a2ec069.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40185