FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-40243: Use numeric_changed for UCD.numeric by wmeehan · Pull Request #19457 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-40243: Use numeric_changed for UCD.numeric - #19457

Merged
serhiy-storchaka merged 7 commits into
python:mainfrom
wmeehan:bpo-40243
Feb 11, 2026
ConversationCommits (7)ChecksFiles changed
Merged

bpo-40243: Use numeric_changed for UCD.numeric#19457
serhiy-storchaka merged 7 commits into
python:mainfrom
wmeehan:bpo-40243

Conversation

wmeehan commented Apr 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.

https://bugs.python.org/issue40243

bpo-40243: Use numeric_changed for UCD.numeric
2247559 
This was causing `ucd_3_2_0.numeric()` to pick up only decimal
changes between Unicode 3.2.0 and the current version.

ezio-melotti commented May 6, 2022

Copy link
Copy Markdown
Member

This was causing ucd_3_2_0.numeric() to pick up only decimal changes between Unicode 3.2.0 and the current version.

@wmeehan: can you elaborate a bit more on this?

serhiy-storchaka self-requested a review February 28, 2024 17:34

python-cla-bot Bot commented Apr 18, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

serhiy-storchaka approved these changes Feb 11, 2026
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. 👍

Thank you for your contribution, @wmeehan. I apologize that it took so long to do the review.

There was a reorganization in tests, so I rewrote them.

serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Feb 11, 2026
serhiy-storchaka enabled auto-merge (squash) February 11, 2026 20:57
serhiy-storchaka merged commit 3e0322f into python:main Feb 11, 2026
54 checks passed

miss-islington-app Bot commented Feb 11, 2026

Copy link
Copy Markdown

Thanks @wmeehan for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Feb 11, 2026

Copy link
Copy Markdown

Sorry, @wmeehan and @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3e0322ff16f47caa3e273d453f007d3918b8ac80 3.14

miss-islington-app Bot commented Feb 11, 2026

Copy link
Copy Markdown

Sorry, @wmeehan and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3e0322ff16f47caa3e273d453f007d3918b8ac80 3.13

wmeehan mannequin mentioned this pull request May 18, 2022
Closed
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Feb 12, 2026
[3.14] pythongh-84424: Use numeric_changed for UCD.numeric (pythonGH-…
aded042 
…19457)

This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.
(cherry picked from commit 3e0322f)

Co-authored-by: William Meehan <wmeehan@fb.com>

bedevere-app Bot commented Feb 12, 2026

Copy link
Copy Markdown

GH-144731 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Feb 12, 2026
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Feb 12, 2026
[3.13] pythongh-84424: Use numeric_changed for UCD.numeric (pythonGH-…
bc1859c 
…19457)

This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.
(cherry picked from commit 3e0322f)

Co-authored-by: William Meehan <wmeehan@fb.com>

bedevere-app Bot commented Feb 12, 2026

Copy link
Copy Markdown

GH-144732 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 12, 2026
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Feb 12, 2026
[3.14] pythongh-84424: Use numeric_changed for UCD.numeric (pythonGH-…
826189d 
…19457)

This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.
(cherry picked from commit 3e0322f)

Co-authored-by: William Meehan <wmeehan@fb.com>
serhiy-storchaka added a commit that referenced this pull request Feb 12, 2026
[3.13] gh-84424: Use numeric_changed for UCD.numeric (GH-19457) (GH-1…
009583f 
…44732)

This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.
(cherry picked from commit 3e0322f)

Co-authored-by: William Meehan <wmeehan@fb.com>
serhiy-storchaka added a commit that referenced this pull request Feb 12, 2026
[3.14] gh-84424: Use numeric_changed for UCD.numeric (GH-19457) (GH-1…
4d3e8c1 
…44731)

This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.
(cherry picked from commit 3e0322f)

Co-authored-by: William Meehan <wmeehan@fb.com>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
pythongh-84424: Use numeric_changed for UCD.numeric (pythonGH-19457)
dbe6fa1 
This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
pythongh-84424: Use numeric_changed for UCD.numeric (pythonGH-19457)
4dbc464 
This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-84424: Use numeric_changed for UCD.numeric (pythonGH-19457)
734da3b 
This was causing ucd_3_2_0.numeric() to pick up only decimal
changes between Unicode 3.2.0 and the current version.
serhiy-storchaka removed their assignment Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
ezio-melotti Awaiting requested review from ezio-melotti
malemburg Awaiting requested review from malemburg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL