FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it by hroncok · Pull Request #19648 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it - #19648

Merged
zooba merged 1 commit into
python:masterfrom
hroncok:idle256ico
Oct 20, 2020
ConversationCommits (1)ChecksFiles changed
Merged

bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it#19648
zooba merged 1 commit into
python:masterfrom
hroncok:idle256ico

Conversation

hroncok commented Apr 22, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

hroncok requested a review from terryjreedy as a code owner April 22, 2020 07:38
hroncok mentioned this pull request Apr 22, 2020
Merged

terryjreedy commented Apr 22, 2020

Copy link
Copy Markdown
Member

Thank you. I will take care of this when I can, and add the idlelib/NEWS.txt item.

taleinat commented Apr 25, 2020

Copy link
Copy Markdown
Contributor

Referring to @terryjreedy's request on the original PR GH-17473:

@taleinat Ned disposed of the .icns issue. Do you currently have a respository on Windows? If so, can you verify that IDLE runs with the current patch and new .ico file?

Tested now, works great on my Windows 10 machine.

zooba merged commit faddc74 into python:master Oct 20, 2020
hroncok deleted the idle256ico branch October 20, 2020 12:25

miss-islington commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

Thanks @hroncok for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

Thanks @hroncok for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

bedevere-bot commented Oct 20, 2020

Copy link
Copy Markdown

GH-22823 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2020
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (python…
d9e6242 
…GH-19648)

(cherry picked from commit faddc74)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2020
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (python…
29c1edb 
…GH-19648)

(cherry picked from commit faddc74)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>

bedevere-bot commented Oct 20, 2020

Copy link
Copy Markdown

GH-22824 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Oct 20, 2020
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (GH-19648)
d84e411 
(cherry picked from commit faddc74)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
miss-islington added a commit that referenced this pull request Oct 21, 2020
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (GH-19648)
871c6cc 
(cherry picked from commit faddc74)

Co-authored-by: Miro Hrončok <miro@hroncok.cz>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-38439: Add 256px IDLE icon to the .ico, drop gifs from it (python…
6b4980f 
…GH-19648)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy Awaiting requested review from terryjreedy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL