FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-40334: Rename PyConfig.use_peg to _use_peg_parser by vstinner · Pull Request #19670 · python/cpython · GitHub

/ cpython Public

bpo-40334: Rename PyConfig.use_peg to _use_peg_parser - #19670

Merged
vstinner merged 3 commits into
python:masterfrom
vstinner:pyconfig_peg
Apr 23, 2020
ConversationCommits (3)ChecksFiles changed
Merged

bpo-40334: Rename PyConfig.use_peg to _use_peg_parser#19670
vstinner merged 3 commits into
python:masterfrom
vstinner:pyconfig_peg

Conversation

vstinner commented Apr 23, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member
  • Rename PyConfig.use_peg to _use_peg_parser
  • Document PyConfig._use_peg_parser and mark it a deprecated
  • Mark -X oldparser option and PYTHONOLDPARSER env var as deprecated
    in the documentation.
  • Add use_old_parser() and skip_if_new_parser() to test.support
  • Remove sys.flags.use_peg: use_old_parser() uses
    _testinternalcapi.get_configs() instead.
  • Enhance test_embed tests

https://bugs.python.org/issue40334

bpo-40334: Rename PyConfig.use_peg to _use_peg_parser
1bfffb7 
* Rename PyConfig.use_peg to _use_peg_parser
* Document PyConfig._use_peg_parser and mark it a deprecated
* Mark -X oldparser option and PYTHONOLDPARSER env var as deprecated
  in the documentation.
* Add use_old_parser() and skip_if_new_parser() to test.support
* Remove sys.flags.use_peg: use_old_parser() uses
  _testinternalcapi.get_configs() instead.
* Enhance test_embed tests
vstinner mentioned this pull request Apr 23, 2020
Merged

vstinner commented Apr 23, 2020

Copy link
Copy Markdown
Member Author

See also PR #19669.

lysnikolaou approved these changes Apr 23, 2020
View reviewed changes

lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is really much better. Thanks!

vstinner requested a review from gpshead as a code owner April 23, 2020 00:37
vstinner merged commit 1def775 into python:master Apr 23, 2020
vstinner deleted the pyconfig_peg branch April 23, 2020 01:03
terryjreedy mentioned this pull request Jun 5, 2020
Merged
terryjreedy added a commit that referenced this pull request Jun 5, 2020
[3.8] bpo-40807: Backport test_codeop change [GH-19670]
a5d6aba 
A tiny sliver of a 3.9 PEG parser patch needed to backport the test added by #20486.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2020
[3.8] bpo-40807: Backport test_codeop change [pythonGH-19670]
9cc2b21 
A tiny sliver of a 3.9 PEG parser patch needed to backport the test added by pythonGH-20486.
(cherry picked from commit a5d6aba)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy added a commit that referenced this pull request Jun 5, 2020
[3.8] bpo-40807: Backport test_codeop change [GH-19670]
12d3061 
A tiny sliver of a 3.9 PEG parser patch needed to backport the test added by GH-20486.
(cherry picked from commit a5d6aba)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lysnikolaou lysnikolaou approved these changes
gpshead Awaiting requested review from gpshead

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL