FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-40443: Remove unused imports in idlelib by vstinner · Pull Request #19801 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-40443: Remove unused imports in idlelib - #19801

Merged
terryjreedy merged 1 commit into
python:masterfrom
vstinner:remove_unused_imports_idle
Apr 30, 2020
ConversationCommits (1)ChecksFiles changed
Merged

bpo-40443: Remove unused imports in idlelib#19801
terryjreedy merged 1 commit into
python:masterfrom
vstinner:remove_unused_imports_idle

Conversation

vstinner commented Apr 29, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

vstinner commented Apr 29, 2020

Copy link
Copy Markdown
Member Author

@terryjreedy @csabella: Would you mind to review this PR?

terryjreedy approved these changes Apr 30, 2020
View reviewed changes

terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Non-use verified.

terryjreedy commented Apr 30, 2020

Copy link
Copy Markdown
Member

Don't understand macOS failure, and the abrupt stop. Treating as unrelated intermittent failure.

clang: warning: -framework Tk: 'linker' input unused [-Wunused-command-line-argument]
In file included from /Users/runner/runners/2.169.1/work/cpython/cpython/Modules/_tkinter.c:46:
/Applications/Xcode_11.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/tk.h:86:11: fatal error: 'X11/Xlib.h' file not found
#       include <X11/Xlib.h>
                ^~~~~~~~~~~~
1 error generated.

Python build finished successfully!

...
The following modules found by detect_modules() in setup.py, have been

...

terryjreedy merged commit 6900f16 into python:master Apr 30, 2020

miss-islington commented Apr 30, 2020

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington commented Apr 30, 2020

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2020
bpo-40443: Remove unused imports in idlelib (pythonGH-19801)
1faed73 
(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner <vstinner@python.org>

bedevere-bot commented Apr 30, 2020

Copy link
Copy Markdown

GH-19808 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2020
bpo-40443: Remove unused imports in idlelib (pythonGH-19801)
ff8ab3b 
(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner <vstinner@python.org>

bedevere-bot commented Apr 30, 2020

Copy link
Copy Markdown

GH-19809 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Apr 30, 2020
bpo-40443: Remove unused imports in idlelib (GH-19801)
48ef06b 
(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this pull request Apr 30, 2020
bpo-40443: Remove unused imports in idlelib (GH-19801)
95e208d 
(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner deleted the remove_unused_imports_idle branch April 30, 2020 09:29

vstinner commented Apr 30, 2020

Copy link
Copy Markdown
Member Author

Terry: yeah sadly the macOS CI looks sick :-(

vstinner mentioned this pull request Jun 27, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy terryjreedy approved these changes
csabella Awaiting requested review from csabella

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL