bpo-40465: Deprecate the optional argument to random.shuffle(). - #19867
Merged
rhettinger merged 5 commits intoMay 2, 2020
Merged
bpo-40465: Deprecate the optional argument to random.shuffle().#19867rhettinger merged 5 commits into
rhettinger merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
remilapeyre
reviewed
May 2, 2020
remilapeyre
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Hi, I think there is a typo in the warning message.
Sorry, something went wrong.
Comment thread
Lib/random.py
Outdated
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Please add an entry in What's New.
Sorry, something went wrong.
Comment thread
Doc/library/random.rst
Outdated
Comment on lines
+211
to
+212
| .. deprecated:: 3.9 | ||
| In the future, the optional argument *random* will be removed. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It looks like the shuffle() function is deprecated. It should be specified that the argument is deprecated.
You can also use the deprecated-removed directive to specify the version of removing.
Sorry, something went wrong.
Comment thread
Lib/random.py
Outdated
Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…on into deprecate_shuffle_param
Copy link
Copy Markdown
|
@rhettinger: Please replace # with GH- in the commit message next time. Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40465