bpo-36543: Restore cElementTree and mark it for removal in 3.10 - #19921
Closed
tiran wants to merge 2 commits into
Closed
bpo-36543: Restore cElementTree and mark it for removal in 3.10#19921tiran wants to merge 2 commits into
tiran wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
tiran
force-pushed
the
restore_celementtree
branch
from
c10d287 to
1372fe1
Compare
May 5, 2020 11:57
scoder
reviewed
May 5, 2020
scoder
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM.
Do we need a News entry for this? It's only reverting an alpha change.
Sorry, something went wrong.
Comment thread
Doc/whatsnew/3.9.rst
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
A typo in your own name? That's rare, I guess. ;-)
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
You wouldn't believe me 👍
Sorry, something went wrong.
Comment thread
Lib/xml/etree/cElementTree.py
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| ) | |
| ) | |
| del _warn |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Let's got with GH-19920 instead, shall we? |
Sorry, something went wrong.
This reverts commit b33e525.
tiran
force-pushed
the
restore_celementtree
branch
from
1372fe1 to
23bb770
Compare
May 15, 2020 17:38
Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
restore_celementtree
branch
from
23bb770 to
99cd4ef
Compare
May 15, 2020 17:41
Copy link
Copy Markdown
Member
|
With 3.9 branch created the PR pointed to master will go in for 3.10. |
Sorry, something went wrong.
tiran
added a commit
to tiran/pip
that referenced
this pull request
May 20, 2020
It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn't have cElementTree. I'd like to bring it back with a deprecation warning to drop in 3.10. See: python/cpython#19921 Signed-off-by: Christian Heimes <christian@python.org>
hugovk
reviewed
May 21, 2020
Comment thread
Doc/whatsnew/3.9.rst
| (Contributed by Carl Meyer in :issue:`40360`.) | ||
|
|
||
| * The :mod:`xml.etree.cElementTree` module has been deprecated since Python | ||
| 3.3 and is scheduled to be removed in Python 3.10. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Use more direct wording:
- clearer
- similar to that in xml.etree.elementtree.rst
- fewer words = more readable
Suggested change
| 3.3 and is scheduled to be removed in Python 3.10. | |
| 3.3 and will be removed in Python 3.10. |
Sorry, something went wrong.
This was referenced May 21, 2020
gsnedders
pushed a commit
to gsnedders/html5lib-python
that referenced
this pull request
Jun 10, 2020
It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn't have cElementTree. I'd like to bring it back with a deprecation warning to drop in 3.10. See: python/cpython#19921 Signed-off-by: Christian Heimes <christian@python.org> Signed-off-by: Sam Sneddon <me@gsnedders.com>
Copy link
Copy Markdown
Contributor
|
I merged #20117, which reverts the removal. |
Sorry, something went wrong.
gsnedders
pushed a commit
to gsnedders/html5lib-python
that referenced
this pull request
Jun 17, 2020
It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn't have cElementTree. I'd like to bring it back with a deprecation warning to drop in 3.10. See: python/cpython#19921 Signed-off-by: Christian Heimes <christian@python.org> Signed-off-by: Sam Sneddon <me@gsnedders.com>
gsnedders
pushed a commit
to html5lib/html5lib-python
that referenced
this pull request
Jun 17, 2020
It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn't have cElementTree. I'd like to bring it back with a deprecation warning to drop in 3.10. See: python/cpython#19921 Signed-off-by: Christian Heimes <christian@python.org> Signed-off-by: Sam Sneddon <me@gsnedders.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36543